Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 rewrite: PHPCBF #754

Closed
wants to merge 3 commits into from
Closed

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Feb 2, 2021

Like #753, but into the #747 v2_rewrite branch.

@donnchawp
Copy link
Contributor

My eyes are going square from looking over this. It's large!
I still need to look over wp-cache-phase2.php and wp-cache.php but TBH as it's going into the rewrite branch which doesn't do much anyway so I would be happy to merge it if you are.

@kraftbj
Copy link
Contributor Author

kraftbj commented Feb 2, 2021

I hear ya. I defer to your judgement. The autofixes are almost always fine (I can't think of a time that one actually broke something).

The manual fixes, sure. I'm good with merging.

@nekohayo
Copy link

Hi there, I sadly can't help with this technically but as an enthusiast I'm wondering what's the status and relationship of this PR and PR 747. This appears to be stalled but seemed close to completion? The current mainline/stable version has so many issues that prevent me from having working caching (like Automattic/jetpack#25467, or HTTPS or preload/GC-related heisenbugs, to the point where I don't know what is what anymore) that I'm secretly hoping that this merge request / branch might solve many things in one sweep... I'm just touching wood, expressing my cautious optimism and hoping that this effort has not been abandoned!

@kraftbj kraftbj closed this Jan 30, 2022
@kraftbj kraftbj deleted the add/v2_rewrite/phpcbf branch August 16, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants