Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS fixes for wp-cache-phase2.php #494

Closed
wants to merge 3 commits into from
Closed

PHPCS fixes for wp-cache-phase2.php #494

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2017

WPCS fixes via PHPCS.

@stodorovic
Copy link

Thanks for PR.

It seems OK, but it's hard to check because there are many lines. Please create few PRs. wp-cache-phase2.php has a lot of lines and it's impossible to check entire file in one step. I just created one example which could be easier to check and merge - #495. We could wait merging #495, then submit next PR,... I think that's better approach. Also, it's easier to fix conflicts with other PRs. What you think?

@kraftbj
Copy link
Contributor

kraftbj commented Feb 2, 2021

Going to close this to defer to #754 since the OP has closed their GH account.

@kraftbj kraftbj closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stodorovic @kraftbj