Rewrite the plugin #747
Open
Rewrite the plugin #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes some work on configuration saving.
We'll use it to write to the global config file.
The functions will check if advanced-cache.php exists and WP_CACHE is defined in wp-config.php
The plugin will attempt to create the file advanced-cache.php and add WP_CACHE to wp-config.php
|
Since you're working almost "solo" on this, I'd just approve it. But if you come up with some simple tests so I can say "works", I'd have no problem testing it :) |
Use a HEREDOC to create the advanced-cache.php and add functions to check and add WPCACHEHOME to wp-config.php
Rename the get_cache_dir() function so it has the right prefix.
* Use the config class to get the configuration as we need it to write too for debugging. * Add a new class to add debugging. Next TODO: create a blank configuration files to save to.
Instead of creating a local $config just use $this->config->config.
* Renamed caching to file-cache * Add cache debug setting to admin page. * Added Page class to represent the current page. * And more ..
|
While you are at it, why don't you add php-brotli support to it? This extension is already in some repositories, and most Nginx nowadays support |
Some checks on "cacheability" can only be run after WordPress has loaded so query vars are defined.
Fix UA check, remove url check, and fix privacy status of post check function.
This function will cache various blog settings for the shutdown process since $wpdb may have been destroyed by the time shutdown happens.
* Move query vars into config class. * Add get_cache_meta_information() for non-anon requests. * Add Page set_env() to replace base file to setup request info. * Replace wp_super_cache_request_uri with WPSC_URI constant
* Add get_response_headers * Add get_post_id * Fire wp_set_env on 'template_redirect' so query vars are set. * Put post_id in a config variable.
* Fix the blog cache path since only MU installs with have a "blogs" directory.
This will allow us to use different cache storage backends in the future.
* Move DISABLE_SUPERCACHE and WPCACHEHOME checks into page class. * Delete wp-cache-base code as it was moved elsewhere already. * Define $wp_super_cache_config in pre-wp-cache.php and use object rather than config array. Fix associated code. * Delete wpsc_is_backend - it's moved elsewhere.
* Disable debugging while creating the debug log, or we run into a loop.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial import of framework for rewrite.
Also includes some work on configuration saving.