Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n editor test #96828

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix i18n editor test #96828

merged 1 commit into from
Nov 27, 2024

Conversation

paulopmt1
Copy link
Contributor

Related to #96365

Proposed Changes

  • Removing the openSettings call from the test

Why are these changes being made?

  • Editor settings is already open in the 19.7.0 version so we don't need to try to open it anymore

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@paulopmt1 paulopmt1 merged commit 09ae239 into trunk Nov 27, 2024
11 checks passed
@paulopmt1 paulopmt1 deleted the fix/i18n-tests branch November 27, 2024 13:05
jornp added a commit that referenced this pull request Feb 25, 2025
This effectively reverts PR
#96828.

Without it, the tests seem to freeze.
@jornp jornp mentioned this pull request Feb 25, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants