-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Assembler - Move posts patterns to the top of the list in the write flow #72991
Pattern Assembler - Move posts patterns to the top of the list in the write flow #72991
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~69 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~158 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
...nding/stepper/declarative-flow/internals/steps-repository/pattern-assembler/patterns-data.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again and look good to me as well 👍
We have decided to postpone the alphabetical ordering until we show the categories and changed the order of |
Proposed Changes
posts
patterns at the top of the listOrder patterns by categories alphabeticallyis postponed until we show the categories.The
posts
patterns are shown at the top of the list only when the selected goal isWrite and Publish
. Note that all patterns are shown for all flows, for now.Only in the Write flow, we put
posts
patterns at the top of the listTesting Instructions
Only in the Write flow, put query patterns at the top of the list
posts
patterns are in the top positionposts
patterns are not in the first positionPre-merge Checklist
Related to #72986 #72748 #72565