Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Assembler - Move posts patterns to the top of the list in the write flow #72991

Merged

Conversation

miksansegundo
Copy link
Contributor

@miksansegundo miksansegundo commented Feb 6, 2023

Proposed Changes

  • Only in the Write flow, put posts patterns at the top of the list
  • Order patterns by categories alphabetically is postponed until we show the categories.

The posts patterns are shown at the top of the list only when the selected goal is Write and Publish. Note that all patterns are shown for all flows, for now.

Only in the Write flow, we put posts patterns at the top of the list

Before After
Screenshot 2566-02-08 at 14 07 17 Screenshot 2566-02-08 at 14 01 26

Testing Instructions

Only in the Write flow, put query patterns at the top of the list

  • Create a new site
  • Select the goal "Write and Publish"
  • Access the assembler from the bottom of the design picker by clicking "Start designing"
  • Add sections and check the posts patterns are in the top position
  • Go back to the goals step and this time don't select any goal, continue, and access the assmbler
  • Verify that the posts patterns are not in the first position

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #72986 #72748 #72565

@miksansegundo miksansegundo requested a review from a team February 6, 2023 05:48
@miksansegundo miksansegundo self-assigned this Feb 6, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

@matticbot
Copy link
Contributor

matticbot commented Feb 6, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~69 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +274 B  (+0.0%)      +69 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~158 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
site-setup-flow           +196 B  (+0.0%)      +69 B  (+0.0%)
site-assembler-flow       +196 B  (+0.7%)      +89 B  (+1.3%)
import-flow               +196 B  (+0.0%)      +69 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@miksansegundo miksansegundo changed the title Pattern Assembler - Put query patterns at the top of the list only in the write flow Pattern Assembler - Order patterns by categories alphabetically and in the write flow move posts to the top Feb 7, 2023
Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and look good to me as well 👍

@miksansegundo miksansegundo changed the title Pattern Assembler - Order patterns by categories alphabetically and in the write flow move posts to the top Pattern Assembler - Move posts patterns to the top of the list in the write flow Feb 8, 2023
@miksansegundo
Copy link
Contributor Author

We have decided to postpone the alphabetical ordering until we show the categories and changed the order of posts patterns to make them look more appealing at the top of the list in the Write flow.

@miksansegundo miksansegundo merged commit 5ca74cb into trunk Feb 8, 2023
@miksansegundo miksansegundo deleted the fix/site-assembler-order-query-patterns-in-write-flow branch February 8, 2023 07:55
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants