Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Assembler - Move query patterns to the top of the list for all flows #72986

Closed
wants to merge 2 commits into from

Conversation

miksansegundo
Copy link
Contributor

@miksansegundo miksansegundo commented Feb 6, 2023

Proposed Changes

  • Put query patterns at the top of the list

Note that all patterns are shown for all flows, for now. We could consider to put the query patterns at the top of the list only for the Write flow.

Before After
Screenshot 2566-02-06 at 09 49 44 Screenshot 2566-02-06 at 09 49 32

Testing Instructions

  • Create a new site
  • Select any goal
  • Access the assembler from the bottom of the design picker
  • Add sections and check the query patterns are in the top position

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #72748 #72565

@miksansegundo miksansegundo self-assigned this Feb 6, 2023
@miksansegundo miksansegundo requested a review from a team February 6, 2023 02:55
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~12 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
site-setup-flow            -50 B  (-0.0%)       -7 B  (-0.0%)
site-assembler-flow        -50 B  (-0.2%)       -5 B  (-0.1%)
import-flow                -50 B  (-0.0%)       -7 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@autumnfjeld
Copy link
Contributor

From slack p1675653948913619/1675653762.313939-slack-CRWCHQGUB

:alphabet-white-question: Do you think we should put these patterns on the top for all flows? For all flows or only for the Write flow?

Hmmmm, no I don't think so.

I think for the Build flow it is fine to keep them mixed in. Anyway this will all soon change with the categories work.

@miksansegundo
Copy link
Contributor Author

In case we want to change the position of the "Posts" patterns based on the intent, I've created another PR.

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2023
@sirreal sirreal deleted the fix/site-assembler-order-query-patterns branch January 14, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants