Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable feature flag to unlock blank-canvas-3 #71708

Merged
merged 5 commits into from
Jan 10, 2023
Merged

Conversation

bangank36
Copy link
Contributor

@bangank36 bangank36 commented Jan 5, 2023

Proposed Changes

  • Include parameter to /themes endpoint in order to unlock blank-canvas-3 on theme showcase

Testing Instructions

Include blank-canvas-3 in the result

  • Apply D97205-code to your sandbox
  • Log out from your wp account
  • Access theme showcase via /themes
  • Confirm that the blank-canvas-3 theme is included in the theme list
Before After
sQTfMb.png sQTfMb.png

Destination for /with-theme flow is patternAssembler

  • After select the blank-canvas-3 theme, you Pick this design and create a new site
  • Confirm the step /patternAssembler is redirected instead of /home
  • Since we does not go to design-setup step, the PA step will redirected to /goals right away, I'd propose the patch for this in follow-up PR

deBSze.mov

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #71706

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@matticbot
Copy link
Contributor

This PR modifies the release build for odyssey-stats

To test your changes on WordPress.com, run install-plugin.sh odyssey-stats add/unlock-bc-theme on your sandbox.

To deploy your changes after merging, see the documentation: PejTkB-3N-p2

@matticbot
Copy link
Contributor

matticbot commented Jan 5, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~112 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
signup                     +150 B  (+0.0%)      +73 B  (+0.1%)
themes                      +94 B  (+0.0%)      +39 B  (+0.0%)
theme                       +94 B  (+0.0%)      +39 B  (+0.0%)
checkout                    +94 B  (+0.0%)      +39 B  (+0.0%)
videopress-flow             +91 B  (+0.0%)      +39 B  (+0.0%)
newsletter-flow             +91 B  (+0.0%)      +39 B  (+0.0%)
link-in-bio-tld-flow        +91 B  (+0.0%)      +39 B  (+0.0%)
link-in-bio-flow            +91 B  (+0.0%)      +39 B  (+0.0%)
jetpack-connect             +91 B  (+0.0%)      +39 B  (+0.0%)
free-flow                   +91 B  (+0.0%)      +39 B  (+0.1%)
accept-invite               +91 B  (+0.0%)      +39 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~83 bytes added 📈 [gzipped])

name                                     parsed_size           gzip_size
async-load-signup-steps-theme-selection        +94 B  (+0.1%)      +42 B  (+0.1%)
async-load-design-blocks                       +94 B  (+0.0%)      +41 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@bangank36 bangank36 requested a review from a team January 9, 2023 14:52
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 9, 2023
@bangank36 bangank36 requested a review from fushar January 10, 2023 00:20
@bangank36 bangank36 merged commit dfbae0c into trunk Jan 10, 2023
@bangank36 bangank36 deleted the add/unlock-bc-theme branch January 10, 2023 09:47
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2023
@bangank36
Copy link
Contributor Author

bangank36 commented Jan 17, 2023

Patch for pre-select design ( to prevent the flow to be redirected to /goals ) can be found here #71852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants