Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂ Pattern Assembler flow in logged-out Theme Showcase #71706

Closed
5 tasks done
bangank36 opened this issue Jan 5, 2023 · 9 comments
Closed
5 tasks done

☂ Pattern Assembler flow in logged-out Theme Showcase #71706

bangank36 opened this issue Jan 5, 2023 · 9 comments
Assignees

Comments

@bangank36
Copy link
Contributor

bangank36 commented Jan 5, 2023

Description

The logged-out theme showcase, which is access from wordpress.com/themes currently did not showing blank-canvas-3 ( BC) theme. This issue will bring the BC to theme showcase and navigate user to /patternAssembler step after picking BC and sign up

  • POC video
    deBSze.mov

Dev tasks

Testing

  • Log out from wp account and visit the /themes showcase
  • Choosing BC theme ( in a form of the blank canvas CTA )
  • Finish sign up
  • Then you should land on /patternAssembler step
  • Finish adding patterns & land on /site-editor

Reference

  • Spike issue can be found here

@Automattic/lego

@bangank36 bangank36 self-assigned this Jan 5, 2023
@autumnfjeld autumnfjeld changed the title Site Assembler flow in logged-out Theme Showcase Pattern Assembler flow in logged-out Theme Showcase Jan 5, 2023
@autumnfjeld
Copy link
Contributor

FYI I renamed this issue to "Pattern Assembler ...." to keep consistency with 🔍 [Spike] Pattern Assembler: Make a POC for blog patterns (aka query block patterns)

:)

@bangank36
Copy link
Contributor Author

Update for unlocking blank-canvas-3 in the API, we decided to not unlock the theme for the /wp-admin/themes for now, since it would require logged-in user for visiting that page.
Check D97205-code for the discussions

@bangank36
Copy link
Contributor Author

Regarding to /with-theme theme parameter

  • I tried to access the getChecklistThemeDestination dependencies find out the theme param is not available
  • Since this is a signup flow, it should relate to client/signup/controller.js
  • I found out how the ref value is added into signup dependencies
  • We can follow this to add the theme param to tweak the with-theme flow destination

@bangank36 bangank36 changed the title Pattern Assembler flow in logged-out Theme Showcase ☂ Pattern Assembler flow in logged-out Theme Showcase Jan 10, 2023
@bangank36
Copy link
Contributor Author

bangank36 commented Jan 10, 2023

Tue, Jan 2023

@autumnfjeld
Copy link
Contributor

Next: for the rest of the week I will try to finish basic feature of this issue, allowing user to lands on PA step without redirecting back to /goals due to lack of design

@bangank36 What do you mean "lack of design" ?

Looking forward to testing the whole flow out. 😃

@bangank36
Copy link
Contributor Author

@autumnfjeld I mean the selectedDesign from the /designSetup step #69780

@bangank36
Copy link
Contributor Author

@fushar with this diff D97579-code is going to be deployed, I think we need to change the usage of feature flag pattern-assembler/logged-out-showcase, to make sure the PA flow will only be introduced after this issue has been completed.
Check out PR #71962

@autumnfjeld
Copy link
Contributor

@bangank36 @taipeicoder Flagging this issue in case it is 1) something that might impact this work 2) something we might able to help out with:

Themes: Point the Logged Out Upsell to the Signup Flow https://github.com/Automattic/dotcom-forge/issues/1454

@arthur791004
Copy link
Contributor

Closing it as it's shipped to the production via #73219. Here is the announcement: p7DVsv-gwG-p2. We'll continue to audit the metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants