-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FSE plugin to version 1.11.0 #43857
Conversation
Caution: This PR affects files in the FSE Plugin on WordPress.com D45821-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Unfortunately this doesn't include #43792 which I just have merged now. Could you do another run and update? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Block Patterns: Fix custom font size in previews Fix block pattern previews with custom font size #43546
- FSE Plugin: Block Pattern Preview Viewport Scaling Modify Block Pattern Preview Viewport #43362
✅ Works on simple sites
✅ Works on atomic sites
✅ Works on atomic site without the Gutenberg plugin
✅ Works on Calypso and wp-admin for all the mentioned sites
Thanks @akirk — I'll rebase and include it! |
8c72433
to
601d7d2
Compare
The change in #43792 to update the text domains for the newspack blocks doesn't seem to be working properly in the CI build. I've commented more fully over in that PR: #43792 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Automattic/serenity can you please double-check that the commits included in this release are working correctly? I'm not so familiar with the Donations or Premium Content blocks, so just want to make sure it's all good to go!
All good from our side!
- name: Run composer | ||
uses: nick-zh/composer-php@master | ||
with: | ||
action: 'install' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are Composer packages cached in Circle CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate on that question? We're using Github Actions here, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 hah, of course no circle ci here.
So e.g. node_modules
gets cached so that running yarn
is faster, and I was wondering if results from composer install
also could get cached?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I am by no means an expert in this realm. All I can say that the time added by the composer install was really minimal, so I am not sure if it's worth trying to cache something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good then! :-) 👍 Thanks for checking the time.
This PR bumps the FSE plugin version to v1.11.0 for rolling out another release. It includes a fair few changes based on looking at https://github.com/Automattic/wp-calypso/commits/master/apps/full-site-editing. I've cross-referenced these below:
Included changes:
Testing instructions
If approving this PR, please approve D45821-code, too :)
@Automattic/serenity can you please double-check that the commits included in this release are working correctly? I'm not so familiar with the Donations or Premium Content blocks, so just want to make sure it's all good to go!