FSE: Run phpcbf on the synced files to fix text domain

[akirk]

In the current FSE release we have gettext calls with the wrong text domain: https://plugins.trac.wordpress.org/browser/full-site-editing/trunk/newspack-blocks/synced-newspack-blocks/blocks/homepage-articles/view.php#L218

Changes proposed in this Pull Request

• Fix the text domain of the synced newspack blocks

Testing instructions

cd apps/full-site-editing
yarn run sync:newspack-blocks --branch=master
grep "post author" full-site-editing-plugin/blog-posts-block/newspack-homepage-articles/blocks/homepage-articles/view.php

If you receive an error message like ERROR: Referenced sniff "PHPCompatibility" does not exist either put your vendor/bin directory into the path or make sure that you have installed the sniff (for example with composer global require phpcompatibility/php-compatibility).

This should show gettext calls with a parameter full-site-editing, not newspack-blocks.

[matticbot]

Test live: https://calypso.live/?branch=fix/fse-php-textdomain

[matticbot]

Caution: This PR affects files in the FSE Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D45699-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[simison]

Usually in bash I see variables like this wrapped with "" but I see that's not the case in lines above. 🙃

Just notion, no need changes.

[simison]

@obenland 👋 can you help with the Newspack sync script review?

[yuliyan]

Tested, works as described.

[wp-desktop]

WordPress Desktop CI Failure (ci/wp-desktop): @akirk please re-try this workflow ("Rerun Workflow from Failed") and/or review this PR for breaking changes. Please also ensure this branch is rebased off latest Calypso master.

ci/wp-desktop passing, closing review

[andrewserong]

@akirk apologies I didn't catch this sooner, but while testing out the version bump for the FSE plugin in #43857 where I've rebased it to include this PR, it looks like the CI (Github Actions) build is failing on this call to phpcbf. This means that the synced diff doesn't include the change to the text domain. We can run phpcbf manually on the diff, of course, but it'd be good to fix it in CI so that we don't accidentally miss it, particularly if subsequent commits to a PR update the diff. It'd also be great to get failing phpcbf to fail the build, too if we can.

Here's the error I can see in the Build FSE Plugin > Build packages step for #43857:

@automattic/full-site-editing: $ check-npm-client && yarn run sync:newspack-blocks --nodemodules
@automattic/full-site-editing: $ check-npm-client && ./bin/sync-newspack-blocks.sh --nodemodules
@automattic/full-site-editing: Syncing files to FSE…
@automattic/full-site-editing: Fixing the text domains…
@automattic/full-site-editing: eslint --fix: done
@automattic/full-site-editing: ./bin/sync-newspack-blocks.sh: line 132: ../../vendor/bin/phpcbf: No such file or directory
@automattic/full-site-editing: phpcbf: !! There was an error executing phpcbf
@automattic/full-site-editing: Updated Newspack version 'v1.7.0'
@automattic/full-site-editing: Sync done.

From looking at the error message, it sounds like the ubuntu-latest environment we're using doesn't have it installed, but it has PHP and composer, so I wonder if we added a step to run composer install before building the packages, if that'd work? @noahtallen just pinging you because you have a lot more experience in this area and recently worked on the Run phpcs step — the challenge here is that we need to be able to use phpcbf well before we're currently using phpcs in the current build steps.

Also, for some reason, in the build for this PR, it looks like the Build packages step was skipped. This is the first time I've looked at the Github Actions for the FSE plugin, so all this is new to me! :)

[andrewserong]

Update: Alex has resolved this in #43857 by adding the step to install composer in the Github Action before phpcbf is called.