Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(donations): prevent warning on coupon filter #2822

Closed
wants to merge 1 commit into from

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

The woocommerce_coupons_enabled filter is also applied in the Woo settings page. This PR prevents the donation-related filter from running in this context.

How to test the changes in this Pull Request:

  1. While on the master branch, visit Woo settings page
  2. Confirm you get the wc_get_product was called incorrectly. warning in the PHP logs
  3. Check out this branch, refresh and confirm the warnings are gone

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 19, 2023
@miguelpeixe miguelpeixe self-assigned this Dec 19, 2023
@miguelpeixe miguelpeixe requested a review from a team as a code owner December 19, 2023 22:19
@miguelpeixe
Copy link
Member Author

This is not needed here and is being tackled in #2805

@miguelpeixe miguelpeixe deleted the fix/disable-coupons-admin branch December 20, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant