feat: modal checkout redesign tweaks

[miguelpeixe]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Combines #2794 and #2771 for Automattic/newspack-blocks#1602.

2aaa84a skips reCAPTCHA when only performing form validation. There's no need for the extra API request if it's already performed while placing the order.

29ca892 moves the custom text for the order button to the main plugin's donation feature. It's best if the modal checkout, where it currently is, doesn't handle donation-specific tweaks.

Also changes how the initializer method registers hooks. I noticed all the hooks are registered inside a ! is_admin() condition, which doesn't seem like good practice. The origin of this is here #225 and the intention is to prevent the process_donation_form, hooked to wp_loaded from running in the admin. This check was moved to inside the process_donation_form, which is more appropriate for that purpose.

How to test the changes in this Pull Request:

Instructions at Automattic/newspack-blocks#1602

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

Looking good! Very minor feedback below.

[miguelpeixe]

Update: 6ff7dd0 tweaks the "cover fee" so it updates more instances in which the price is rendered. Fixes an issue when rendering the order review table: Automattic/newspack-blocks#1602 (review)

[miguelpeixe]

The solution proposed in 6ff7dd0 doesn't work well. Every price is being contained in the newspack-wc-price class, so the result is this:

To properly implement the "cover fee" integrated with Woo's taxes or other features that may impact the final order price, the strategy for this might have to change. It's currently not working well in master either, so I think we should tackle it separately so it's no tied to this epic.

[miguelpeixe]

More on the "cover fee". The design proposes adding a row to the table, which seems like a better approach which also seems to better integrate with how Woo does things:

cc @adekbadek

[miguelpeixe]

I started a draft here to refactor the cover fee approach to use Woo's WC()->cart->add_fee(). This should be tackled outside of the RAS-ACC project since it's affecting live sites.

[dkoo]

I started a draft here to refactor the cover fee approach to use Woo's WC()->cart->add_fee(). This should be tackled outside of the RAS-ACC project since it's affecting live sites.

Sounds good! In that case this looks good.

[matticbot]

🎉 This PR is included in version 3.0.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.6.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.9.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.4.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀