Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled gallery block: load block outside the tiled-gallery module #10753

Closed
simison opened this issue Nov 30, 2018 · 4 comments
Closed

Tiled gallery block: load block outside the tiled-gallery module #10753

simison opened this issue Nov 30, 2018 · 4 comments
Assignees
Labels
[Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] High
Milestone

Comments

@simison
Copy link
Member

simison commented Nov 30, 2018

Currently, tiled gallery block relies on Tiled gallery module, which relies on the Photon module.

If we don't rely on Photon for the layouts, there's no reason to hide Tiled gallery block when user disables Photon. The block doesn't rely on anything from the Jetpack module neither, so perhaps the gallery should always be available.

Test by disabling Photon ("speed up image load times"):

image

Tiled gallery block should't now load assets in frontend. The editor side currently loads regardless of the module.

You can test the block following instructions from Automattic/wp-calypso#28944

cc @MichaelArestad @jeherve

@simison simison added [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Nov 30, 2018
@simison simison added this to the 6.9 milestone Nov 30, 2018
@simison simison changed the title Tiled gallery block: load outside the module Tiled gallery block: load block outside the tiled-gallery module Nov 30, 2018
@jeherve
Copy link
Member

jeherve commented Nov 30, 2018

The block doesn't rely on anything from the Jetpack module neither, so perhaps the gallery should always be available.

It does indeed seem like the easiest solution, although not without potential issues. We face similar problems with the Markdown block. See #10294 (comment)

@jeherve
Copy link
Member

jeherve commented Nov 30, 2018

Related discussion: pafL3P-aF-p2

@sirreal
Copy link
Member

sirreal commented Dec 28, 2018

We're relying on Photon for the block, but we're not relying on the Tiled Gallery module for the block 🙃

I'd like to remove the dependence on the Tiled Gallery module and instead rely on Photon.

Related: Automattic/wp-calypso#29495

CC: @MichaelArestad

@MichaelArestad
Copy link
Contributor

I'd like to remove the dependence on the Tiled Gallery module and instead rely on Photon.

You have my blessing.

jeherve added a commit that referenced this issue Jan 2, 2019
Fixes #10753

With this PR, one can use the Tiled Gallery block on their site even
if the Tiled Gallery module is not active. The block, however, relies
on the Photon module.
@jeherve jeherve self-assigned this Jan 2, 2019
jeherve added a commit that referenced this issue Jan 3, 2019
Fixes #10753

With this PR, one can use the Tiled Gallery block on their site even
if the Tiled Gallery module is not active. The block, however, relies
on the Photon module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] High
Projects
None yet
Development

No branches or pull requests

4 participants