Iteration of Tiled Gallery settings #7576
Comments
MichaelArestad
added
[Feature] Tiled Gallery
|
That's so much more clear. Also cc @dereksmart |
|
Benefits:
|
|
Maybe this should be a separate issue, but...
The second line says
But the first line doesn't mention a carousel, so it's kinda confusing. Should we change the first line to:
|
|
Good catch @danjjohnson. We should also remove the word 'gorgeous'—that editorialization didn't make it into the wordpress.com version of these settings and doesn't add much. It's merely our opinion that it's gorgeous. |
|
This issue has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
|
This could still be beneficial. |
|
This issue has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
|
Related: #10753 |
|
This issue has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
The existing Site Accelerator toggle under Jetpack > Settings > Performance acts as a "multi-toggle". When you toggle it, it toggles the 2 child settings below it: Photon and Asset CDN (aka photon-cdn). Behind the scenes, that toggle also controls 2 additional settings: - It enables Tiled Galleries, the module that adds gallery type settings to the classic gallery modal. - It enables the option that makes all existing classic galleries use the Tiled Gallery style by default (that option is visible under Settings > Media in wp-admin). We built things this way before the block editor, and before we had a Tiled Gallery block that would be available and function regardless of your Photon settings. For "classic" tiled galleries (the ones that can be created via the classic editor or a classic block), the images rely on Photon to be resized on the fly. We consequently opted to enable the Tiled Galleries module as soon as you would turn on the Photon module, since the latter gave you the option to use tiled galleries. Admittedly, things got a bit more complicated when the block editor and the Tiled Gallery block were introduced, but the basic idea remains: when you enable the Photon module, you should get access to the option to pick different gallery types when creating or editing galleries. For more details around this behaviour, you can check #7576. This commit takes that existing behaviour, and brings it to the new Site Accelerator toggle we added in the Recommendations tab in #18437. When you enable Site Accelerator there, you'll also enable Tiled Galleries behind the scenes.
…19022) The existing Site Accelerator toggle under Jetpack > Settings > Performance acts as a "multi-toggle". When you toggle it, it toggles the 2 child settings below it: Photon and Asset CDN (aka photon-cdn). Behind the scenes, that toggle also controls 2 additional settings: - It enables Tiled Galleries, the module that adds gallery type settings to the classic gallery modal. - It enables the option that makes all existing classic galleries use the Tiled Gallery style by default (that option is visible under Settings > Media in wp-admin). We built things this way before the block editor, and before we had a Tiled Gallery block that would be available and function regardless of your Photon settings. For "classic" tiled galleries (the ones that can be created via the classic editor or a classic block), the images rely on Photon to be resized on the fly. We consequently opted to enable the Tiled Galleries module as soon as you would turn on the Photon module, since the latter gave you the option to use tiled galleries. Admittedly, things got a bit more complicated when the block editor and the Tiled Gallery block were introduced, but the basic idea remains: when you enable the Photon module, you should get access to the option to pick different gallery types when creating or editing galleries. For more details around this behaviour, you can check #7576. This commit takes that existing behaviour, and brings it to the new Site Accelerator toggle we added in the Recommendations tab in #18437. When you enable Site Accelerator there, you'll also enable Tiled Galleries behind the scenes.
jeherve
added
Admin Page
Currently Tiled Gallery is connected to Photon in settings. It looks like this:
After some discussion with @rickybanister, we think it would be a good idea to move it and provide access to a suboption that is missing from Jetpack Settings, yet available in wp-admin.
It would look like this:
We would also need to remember to update the search keywords and one-way updates for tiled galleries.
We should also mirror this change in Calypso. CC @tyxla @oskosk
The text was updated successfully, but these errors were encountered: