Tiled Galleries: do not rely on the Tiled Gallery module.

[jeherve]

Fixes #10753

Changes proposed in this Pull Request:

With this PR, one can use the Tiled Gallery block on their site even
if the Tiled Gallery module is not active. The block, however, relies
on the Photon module.

Testing instructions:

• Go to Jetpack > Settings
• Disable the "Speed up image load times" option
• Load the block editor.
• The tiled gallery block should not be available.
• If, however, you go back and enable the "Speed up image load times" option, the block will become available.

Proposed changelog entry for your changes:

• Tiled Gallery block: do not rely on the Tiled Gallery module.

[matticbot]

D22751-code. (newly created revision)

[jetpackbot]

	Fails
🚫	Danger failed to run dangerfile.js.

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Error TypeError

github.api.issues.getMilestones is not a function
TypeError: github.api.issues.getMilestones is not a function
    at _callee$ (dangerfile.js:65:32)
    at tryCatch (/home/travis/build/Automattic/jetpack/node_modules/babel-runtime/node_modules/regenerator-runtime/runtime.js:62:40)
    at Generator.invoke [as _invoke] (/home/travis/build/Automattic/jetpack/node_modules/babel-runtime/node_modules/regenerator-runtime/runtime.js:296:22)
    at Generator.prototype.(anonymous function) [as next] (/home/travis/build/Automattic/jetpack/node_modules/babel-runtime/node_modules/regenerator-runtime/runtime.js:114:21)
    at step (/home/travis/build/Automattic/jetpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /home/travis/build/Automattic/jetpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14
    at new Promise (<anonymous>)
    at new F (/home/travis/build/Automattic/jetpack/node_modules/core-js/library/modules/_export.js:36:28)
    at /home/travis/build/Automattic/jetpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:14:12
    at /home/travis/build/Automattic/jetpack/node_modules/danger/distribution/runner/runners/inline.js:84:32

Dangerfile

60|             const firstTuesdayOfMonth = moment().add( 1, 'months' ).startOf( 'month' );
61|             while ( firstTuesdayOfMonth.day() !== 2 ) {
62|                 firstTuesdayOfMonth.add( 1, 'day' );
63|             }
64|             jetpackReleaseDate = firstTuesdayOfMonth.format( 'LL' );
-------------------------------------------^
65|             // Calculate next code freeze date
66|             codeFreezeDate = firstTuesdayOfMonth.subtract( 7, 'd' ).format( 'LL' );
67|         }
68| 

Generated by 🚫 dangerJS against f1c15c4

[simison]

I'm concerned about the impact to user experience this will have since it's not at all obvious that gallery block depends on "speeding up images" -feature unless we rename that feature somehow.

This is a good first step, but as a next step, would it be possible to rely on Photon URLs without relying on the module being active?

Does Tiled gallery module turn Photon on in the background somehow?

[jeherve]

would it be possible to rely on Photon URLs without relying on the module being active?

That is definitely something we can do. In fact, we already do it for other features of Jetpack like Related Posts or the Top Posts widget: we use Photon, whether you have the module on or not.
In the past we used to do it for Tiled Galleries as well, but it was causing some confusion from folks who wanted to turn off Photon on their site and still saw Photon URLs used in their galleries. They did not understand why. This is why we opted to more clearly rely on the Photon feature. It's not perfect though, I think both solutions have their downsides. I'm not sure what is best.

Ideally, I think we should always have the Tiled Gallery block available, and have it use Photon behind the scenes if the feature is on on the site. I'm not sure this can be done today though.

[gititon]

Tested, worked well.

[brbrr]

tests well

[ockham]

Ideally, I think we should always have the Tiled Gallery block available, and have it use Photon behind the scenes if the feature is on on the site. I'm not sure this can be done today though.

Agree that this seems like a desirable long-term solution.

[ockham]

Code looks good and tests well 👍

[sirreal]

Noting that it looks like D22751-code will need some additional work which we'll need to be sure is synced back here.

[simison]

Syncing back in #11136