-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change races to activities #172
Conversation
@Mathieu414 you might want to rebase to master with this branch! You can also either worktree or stash our progress to make it easier to review, and create another work item! |
7e48a37
to
1e88d3d
Compare
I don't like the current data migration:
If you want to generate an empty migration file with Doctrine, you can use the following command: php bin/doctrine migrations:generate To be clear, the real blocker here is that it does not work. If it would work flawlessly I would probably approve. I however think this migration is dangerous, and would appreciate if you make the code cleaner and less risky to execute. So since it just does not work, I would like if you would try to add a test for the migration! If you want some help creating a test I can of course help out :) |
75d775f
to
ebde724
Compare
- migrate visual and services - add migration helper page
- add helpers and better structure to handle route protection - improve rollback to prevent data corruption - improve user experience
612347d
to
144fa4f
Compare
See the project item for the idea of the changes.
Quite a lot of things. Changed a bit how the data is displayed in the activities accordion, so that it becomes clearer what is the event description and what is your own registration.