Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework of the control script #45

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Conversation

pierfabre
Copy link
Collaborator

No description provided.

@pierfabre pierfabre requested a review from Armandpl January 12, 2024 23:24
@pierfabre pierfabre self-assigned this Jan 12, 2024
@pierfabre pierfabre linked an issue Jan 12, 2024 that may be closed by this pull request
6 tasks
@pierfabre
Copy link
Collaborator Author

pierfabre commented Jan 12, 2024

ready for first round of review @Armandpl
Also what do you think of moving robot.py in robot/software?
Needs to be tested on the robot before merge

Copy link
Owner

@Armandpl Armandpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • need to move the library code to the furuta package
  • later we might also want to move from manual instantiation from json files to using hydra but for now that's 100% ok
    • hydra will makes sense if uses cases for it arise in the control theory code
    • will also makes sens for coherence, so that rl and control experiments are instantiated/configured the same way
      apart from that lgtm <3

scripts/control.py Outdated Show resolved Hide resolved
scripts/control.py Outdated Show resolved Hide resolved
robot/software/controllers.py Outdated Show resolved Hide resolved
@Armandpl Armandpl merged commit 6a271d7 into master Jan 14, 2024
1 check failed
@Armandpl Armandpl deleted the 44-rework-the-control-script branch January 14, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework the control script
2 participants