Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

27 match sim timing to robot #36

Merged
merged 20 commits into from
Dec 2, 2023
Merged

27 match sim timing to robot #36

merged 20 commits into from
Dec 2, 2023

Conversation

Armandpl
Copy link
Owner

@Armandpl Armandpl commented Dec 2, 2023 •
edited
Loading

  • refactor to better match sim to real robot, not working yet
  • also some utils things: hydra to conf experiments, better pre-commit config

Armandpl added 20 commits January 3, 2023 15:50
@Armandpl
return obs at t instead of t+1
ed529e3
@Armandpl
update pre-commit conf
a133555
@Armandpl
make thin wrapper to be able to pass omegaconf lists instead of tuple…
f6799e4 
…s to SAC
@Armandpl
rename common to utils; add indexing constants
1b7a5ac
@Armandpl
- fix error where last mcap file did't get closed and got corrupted
78a9ccf 
- include continuity cost in info dict
@Armandpl
minor refactoring
adc499e
@Armandpl
allow passing sim params when instantiating env
7533480
@Armandpl
remove unused imports
d1469cc
@Armandpl
first pass at using hydra to configure experiments
1468071
@Armandpl
move eval params
324e7c3
@Armandpl
only save video of the last episode
edc6f0e
@Armandpl
- (seemingly) fix bug when eval env is the same object as env
eec07fe 
- include hydra config in run config
@Armandpl
- correctly render when doing more than one rev
e5ec0e0 
- remove action limiter
- make state limits configurable
@Armandpl
update hardware readme
62a8c66
@Armandpl
add configs
f2dded1
@Armandpl
round to encoder res; try optim; use vel filt even in sim
e7aef6a
@Armandpl
update reward; comment out slow assert
1f108f4
@Armandpl
update init args
f2c960d
@Armandpl
eh
3e21cfd
@Armandpl
merge 24
a634f4a
@Armandpl Armandpl linked an issue Dec 2, 2023 that may be closed by this pull request
match sim timing to robot #27
Closed
@Armandpl Armandpl merged commit 26421e9 into master Dec 2, 2023
1 check failed
@Armandpl Armandpl deleted the 27-match-sim-timing-to-robot branch December 2, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

match sim timing to robot
1 participant
@Armandpl