Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_Motors: Change to pass-through #24246

Merged
merged 1 commit into from
Sep 24, 2024
Merged

AP_Motors: Change to pass-through #24246

merged 1 commit into from
Sep 24, 2024

Conversation

muramura
Copy link
Contributor

@muramura muramura commented Jul 7, 2023

With pass-through, processing is combined into one.

@IamPete1
Copy link
Member

IamPete1 commented Jul 8, 2023

you could do the same clean up in AP_MotorsSingle too.

@peterbarker
Copy link
Contributor

This enumeration is specfied as an array offset, so I think this subtraction is actually reasonable.

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *
Durandal                            *      *           -56     *                 *      *      *
Hitec-Airspeed           *
KakuteH7-bdshot                     *      *           -64     *                 *      *      *
MatekF405                           *      *           -64     *                 *      *      *
Pixhawk1-1M-bdshot                  *                  -64     *                 *      *      *
f103-QiotekPeriph        *
f303-Universal           *
iomcu                                                                *
revo-mini                           *      *           -56     *                 *      *      *
skyviper-v2450                                         -64

@rmackay9
Copy link
Contributor

It looks OK but it should be tested I think. So confirmation that someone has tried to fly a coax copter in SITL or on a real vehicle.

@peterbarker
Copy link
Contributor

It looks OK but it should be tested I think. So confirmation that someone has tried to fly a coax copter in SITL or on a real vehicle.

From the FlyEachFrame autotest when flying the COAX frame:
image

@peterbarker peterbarker merged commit 1f5b88c into ArduPilot:master Sep 24, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker approved these changes

Assignees
No one assigned
Labels
MergeOnCIPass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@muramura @IamPete1 @peterbarker @rmackay9 @CraigElder