Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_DDS: Gracefully handle runtime home location change #25774

Open
Ryanf55 opened this issue Dec 14, 2023 · 0 comments
Open

AP_DDS: Gracefully handle runtime home location change #25774

Ryanf55 opened this issue Dec 14, 2023 · 0 comments

Comments

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 14, 2023

Feature request

Is your feature request related to a problem? Please describe.

If the user uses their GCS to change the home location, the published local pose data in DDS will jump. Additionally, applications like terrain planners commanding position in global coordinates with an altitude frame relative to home will have the altitude wrong now. This could cause a crash if the new home location is significantly below the previous one because the plane will fly into the ground.

Describe the solution you'd like

Add a notification in AP_Notify for a home change event, and then use that event to propogate the new home location via the static transform tree. This tree is currently populated in AP_DDS_Client::populate_static_transforms, but does not include the home position.

Describe alternatives you've considered

Prevent the user from changing home when DDS is enabled

Additional context

See #25722, which is vulnerable to a runtime home location change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant