Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): build, release, and productization preparation #5465

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsenko
Copy link
Member

@jsenko jsenko commented Nov 4, 2024

@andreaTP This is a larger one, since it addresses a complex topic. I've added a comprehensive README, please take a look at it and try each step.

@jsenko jsenko requested a review from andreaTP November 4, 2024 21:53
@apicurio-bot
Copy link

apicurio-bot bot commented Nov 4, 2024

Thank you for creating a pull request!

Pinging @EricWittmann to respond or triage.

@apicurio-bot apicurio-bot bot added the area/ui label Nov 4, 2024
@jsenko jsenko removed the area/ui label Nov 4, 2024
and gives you control of their evolution.

**Features**
- TODO
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricWittmann I'd appreciate some input on what to put here. The original list is:

    **Features**
    - Supports: Apache Avro, AsyncAPI, GraphQL, JSON Schema, Kafka Connect Schema, OpenAPI, Protobuf
    - Provides a REST API and web UI to manage the artifacts and artifact meta-data
    - Includes Serializers and Deserializers for Kafka client integration
    - Configurable rules to control schema validity and evolution (compatibility)
    - Storage options: Kafka, PostgreSQL, in-memory
    - Compatible with Confluent and IBM APIs
    - Runs on a lightweight Quarkus platform
    - Includes Maven plugin to integrate with Maven based builds

@jsenko
Copy link
Member Author

jsenko commented Nov 4, 2024

There might be some things to trim, such as operator/deploy/rbac/single-namespace/*. I'll look into those after feedback.

Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last but not least we should have a test of installing the operator via OLM in CI.


- name: Configure env. variables 2
run: |
echo "IMAGE=ttl.sh/apicurio-registry-operator-$UUID:8h" >> $GITHUB_ENV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ttl.sh should not be needed here

kubernetes version: v1.25.0
github token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: keep GITHUB_TOKEN

- name: Update install file
run: |
cd registry/operator
make INSTALL_FILE=install/install.yaml dist-install-file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a job to compare the resulting yaml with the expected and fail instead of automatically pushing it back.

KIND_VERSION ?= 0.23.0
KIND = $(shell pwd)/bin/kind
.PHONY: install-kind
install-kind: ## Install kind v0.23.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

OPERATOR_SDK_VERSION ?= 1.14.0
OPERATOR_SDK = $(shell pwd)/bin/operator-sdk
.PHONY: install-operator-sdk
install-operator-sdk: ## Install operator-sdk v1.14.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify that this is actually used, and operations are not available through opm

- '*'

- apiGroups:
- config.openshift.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed iirc

verbs:
- '*'

- apiGroups:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's open an issue to review roles vs. cluster roles later on.

verbs:
- '*'

- apiGroups:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

verbs:
- '*'

- apiGroups:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

verbs:
- get

- apiGroups:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not effective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants