-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): build, release, and productization preparation #5465
base: main
Are you sure you want to change the base?
Conversation
Thank you for creating a pull request! Pinging @EricWittmann to respond or triage. |
and gives you control of their evolution. | ||
|
||
**Features** | ||
- TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EricWittmann I'd appreciate some input on what to put here. The original list is:
**Features**
- Supports: Apache Avro, AsyncAPI, GraphQL, JSON Schema, Kafka Connect Schema, OpenAPI, Protobuf
- Provides a REST API and web UI to manage the artifacts and artifact meta-data
- Includes Serializers and Deserializers for Kafka client integration
- Configurable rules to control schema validity and evolution (compatibility)
- Storage options: Kafka, PostgreSQL, in-memory
- Compatible with Confluent and IBM APIs
- Runs on a lightweight Quarkus platform
- Includes Maven plugin to integrate with Maven based builds
There might be some things to trim, such as |
9f736d9
to
d218507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last but not least we should have a test of installing the operator via OLM in CI.
|
||
- name: Configure env. variables 2 | ||
run: | | ||
echo "IMAGE=ttl.sh/apicurio-registry-operator-$UUID:8h" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ttl.sh should not be needed here
kubernetes version: v1.25.0 | ||
github token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: keep GITHUB_TOKEN
- name: Update install file | ||
run: | | ||
cd registry/operator | ||
make INSTALL_FILE=install/install.yaml dist-install-file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a job to compare the resulting yaml
with the expected and fail instead of automatically pushing it back.
operator/Makefile
Outdated
KIND_VERSION ?= 0.23.0 | ||
KIND = $(shell pwd)/bin/kind | ||
.PHONY: install-kind | ||
install-kind: ## Install kind v0.23.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used
operator/Makefile
Outdated
OPERATOR_SDK_VERSION ?= 1.14.0 | ||
OPERATOR_SDK = $(shell pwd)/bin/operator-sdk | ||
.PHONY: install-operator-sdk | ||
install-operator-sdk: ## Install operator-sdk v1.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verify that this is actually used, and operations are not available through opm
- '*' | ||
|
||
- apiGroups: | ||
- config.openshift.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed iirc
verbs: | ||
- '*' | ||
|
||
- apiGroups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's open an issue to review roles vs. cluster roles later on.
verbs: | ||
- '*' | ||
|
||
- apiGroups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
verbs: | ||
- '*' | ||
|
||
- apiGroups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
verbs: | ||
- get | ||
|
||
- apiGroups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not effective
d218507
to
cd85037
Compare
@andreaTP This is a larger one, since it addresses a complex topic. I've added a comprehensive README, please take a look at it and try each step.