feat: struct-log based trace-frames now include events emitted #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
feat/events-in-traces
branch
from
4f96bd1
to
f087086
Compare
antazoey
force-pushed
the
feat/events-in-traces
branch
from
c1815f7
to
796d753
Compare
antazoey
changed the title
antazoey
commented
Jun 25, 2024
| return CallTreeNode(**node_kwargs) | ||
|
|
||
|
|
||
| def _create_event_node(frame: TraceFrame) -> EventNode: |
antazoey
force-pushed
the
feat/events-in-traces
branch
from
f6a4ad3
to
0ee7932
Compare
3 tasks
antazoey
commented
Jun 25, 2024
fubuloubu
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Part 1 of getting events into traces, focusing on low level frame data from struct logs because we can accurately inject events into the appropriate parts of the call tree this way
How I did it
How to verify it
Checklist