Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ape test): Include Event definitions in statement-coverage #2160

Open
antazoey opened this issue Jun 25, 2024 · 1 comment
Open

(ape test): Include Event definitions in statement-coverage #2160

antazoey opened this issue Jun 25, 2024 · 1 comment
Labels
category: feature New feature or request

Comments

@antazoey
Copy link
Member

Overview

evm-trace is nearly added the ability to see event-node data from struct-log parsing from geth traces:
ApeWorX/evm-trace#66

with this affords us the ability to include Event definition lines in coverage reports. If an event is defined in a contract but never emitted, its definition would not show as hit in the coverage report.

Specification

  • bump evm-trace
  • when profiling a coverage report (ape-vyper), include event definition lines
  • when covering lines, observe events emitted via LOG* opcodes and match them via their selector data back to the definition lines (don't fully know all the parts to doing this, obviously requires some AST stuff).
  • booyah! make sure ape shows these alright in coverage reports

Dependencies

Include links to any open issues that must be resolved before this feature can be implemented.

@antazoey antazoey added the category: feature New feature or request label Jun 25, 2024
Copy link

linear bot commented Jun 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant