-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fixed Windows Size Settings #394
Add Fixed Windows Size Settings #394
Conversation
I Have also tried to integrate the auto-adjustment feature #383 from @zokradonh in another feature branch. The settings Window then would look like that: But there are a few problems I see (besides that I personally don't like the window jumping at all):
I probably could fix the blank screen issue relatively easy, but the animation part is a bit trickier. Not sure if I want to spend much more time with it - as I don't find the auto-size feature that useful, but maybe other people like/need it much more, than I do. |
@drothmaler Thanks for your work on this feature. I will review shortly and if all is well try to include it in the |
I'd forgotten that the net-5-port branch had already been merged into master :) |
225c868
to
2389d02
Compare
No problem... just reverted the German translation file... |
Thanks - it should get translated by the German translator as soon as I push the changes, but if not I can add your translated terms. |
@drothmaler Super work! Thanks again. A couple of minor changes I would like to make:
What do you think? |
@AntonyCorbett Regarding your comments:
|
@drothmaler I've made these minor changes and accepted the PR |
What does this implement/fix? Explain your changes
As discussed in the issue linked below, for Zoom (or other video) meetings, it would be very handy to be able to preconfigure the size of the media window to ensure a consistent media presentation. So this PR adds the possibility to specify a fixed window resolution in the settings. There are also preset buttons for the most common resolutions (360p, 480p, 720p, 1080p).
Does this close any currently open issues?
#339
Any other comments?
Nope...