Several Bugfixes/Improvements for Fixed Window Size Feature #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Helper This is a much better place for the implementation, as it integrates with the existing window placement logic. It also fixes a bug that made it necessary to restart the app when switching back to Full-Screen mode
AntonyCorbett
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes
Reworked the Fixed Window Size Implementation to better integrate with the existing window positioning logic. This also fixes an issue that caused the need of a restart when switching back to Full-Screen mode.
This basically reverts most of the changes done to the
MediaWindowViewModelIn #394 and places the (now much simpler) logic into theMediaWindowPositionHelperinstead.Also added some validating/limiting logic to the window size settings.
Does this close any currently open issues?
#396 #397
Any other comments?
If you prefer, I could also split the PR in two.