Update lucene to version 8.11.2 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…queries, search as before
I think "a" is not a stop word in this context, because it is a verb here. But my French is not that good.
I don't speak all of these languages, so I sometimes just changed the test to reflect the output. At least that should prevent regression.
|
So summarizing @JJK96 , I would like that we try to:
(related to discussion started here: #15 (comment)) |
Also removed LuceneAnalyzer and moved it's functionality into AnalyzerFactory AnalyzerFactory now returns a real subclass of Analyzer, instead of a wrapper. For all languages, language-specific analyzers are used, instead of Snowball Analyzers
Removed EnglishAnalyzer test in AnalyzerFactoryTest
|
…ries would always search the whole bible.
Added check for index version when getting index status. This ensures that the status correctly represents if the index is invalid.
tuomas2
commented
Nov 14, 2024
notes.md
Outdated
| @@ -0,0 +1,18 @@ | |||
| Functionality AbstractBookAnalyzer | |||
There was a problem hiding this comment.
this file should be deleted before merging, right?
| @@ -44,6 +44,7 @@ public interface Index { | |||
| * @throws BookException | |||
| */ | |||
| Key find(String query) throws BookException; | |||
| Key find(String query, boolean full_text) throws BookException; | |||
There was a problem hiding this comment.
Suggested change
| Key find(String query, boolean full_text) throws BookException; | |
| Key find(String query, boolean fullText) throws BookException; |
| Field headingField = new Field(FIELD_HEADING, "", Field.Store.YES, Field.Index.ANALYZED, Field.TermVector.NO); | ||
| Field headingStemField = new Field(FIELD_HEADING_STEM, "", Field.Store.NO, Field.Index.ANALYZED, Field.TermVector.NO); | ||
| Field morphologyField = new Field(FIELD_MORPHOLOGY , "", Field.Store.NO, Field.Index.ANALYZED, Field.TermVector.NO); | ||
| FieldType stored_not_analyzed = new FieldType(StringField.TYPE_STORED); |
| return createAnalyzer(book, false); | ||
| } | ||
|
|
||
| public Analyzer createAnalyzer(Book book, Boolean stopwording) { |
| analyzerPerField.put(LuceneIndex.FIELD_INTRO_STEM, analyzer); | ||
| analyzerPerField.put(LuceneIndex.FIELD_HEADING_STEM, analyzer); | ||
| //analyzerPerField.put(LuceneIndex.FIELD_HEADING, myNaturalLanguageAnalyzer); //heading to use same analyzer as BODY | ||
| //analyzerPerField.put(LuceneIndex.FIELD_INTRO, myNaturalLanguageAnalyzer); |
| Latest.Index.Version=1.2 | ||
| Lucene.Version=3.0 | ||
|
|
||
| Latest.Index.Version=1.3 |
There was a problem hiding this comment.
Should add comment above (as there seem to be version history)
|
I'll merge these both to develop and start preparing a beta release. Looks good so far, but haven't tested yet in practice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #15
This gave access to some new features in Lucene, such as Regular Expression search. This is a major refactor because I updated Lucene 5 major versions.
I tested several languages, English, Czech, Chinese, Japanese, Thai and search works in these languages. I am not capable to test if the stemming is good for all languages, so some more testing by native speakers is necessary.