Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still maintained ? Else, where should contributions be sent ? #131

Closed
UnasZole opened this issue Jan 13, 2024 · 9 comments
Closed

Comments

@UnasZole
Copy link

Hello,

Is this repository still maintained and open to contributions ?
Seeing as the last commit is from 6 years ago, and the last closed ticket from 7 years ago, I'd like to make sure there is still at least one person at crosswire able to administrate the repository, before I start opening pull requests :-)
@dmsmith are you still around ?

If not, can the and-bible fork at https://github.com/AndBible/jsword , which is still active (and is already the one publishing the maven artifact), be considered a new main reference for JSword ?
@tuomas2 , would you be open to contributions directly on the AndBible jsword fork ; and possibly, to enabling the "Issues" tab on this repository so that it becomes a true new main hub ?

FYI, the first contributions I'm considering making are around the versifications mapping : currently, the provided versifications mapping cover only the KJV bible, ie without deuterocanonical books. And therefore, no mappings at all are provided for versifications such as Catholic or Catholic2, which contain those.
I wanted to extend these mappings to map to KJVA instead, and then provide the mappings for catholic bibles.

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 13, 2024

I'm open to contributions to and-bible jsword fork. Enabled issues tab there now.

@UnasZole
Copy link
Author

Thanks a lot for the very quick answer, that's amazing :-)

@dmsmith
Copy link
Contributor

dmsmith commented Jan 8, 2025

tuomas2

I'm open to contributions to and-bible jsword fork. Enabled issues tab there now.

Can we put our heads together and bring this repository in sync with yours?

@dmsmith
Copy link
Contributor

dmsmith commented Jan 8, 2025

I'm back now that I'm retired. I'm going through old pull requests and am making changes where they still make sense.

  • AndBible's fork is not far off from this repository and I see some good work being done on upgrading Lucene. I think these can be harmonized fairly easily.
  • STEP Bible's fork is way behind this repository and also is way ahead of it. The suggested pull requests do not apply cleanly. It'll take much effort to bring them into harmony.

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 8, 2025

tuomas2

I'm open to contributions to and-bible jsword fork. Enabled issues tab there now.

Can we put our heads together and bring this repository in sync with yours?

It should be rather easy to merge AndBible branch here. You can do it (I encourage you to do it as my time is somewhat limited), or I may do a pull request at some point.

I'm back now that I'm retired. I'm going through old pull requests and am making changes where they still make sense.

Great news! Welcome back!

  • AndBible's fork is not far off from this repository and I see some good work being done on upgrading Lucene. I think these can be harmonized fairly easily.

Lucene work is good indeed (contributed by @JJK96 in AndBible#16) but I'm afraid I can't merge it very soon to my stable branch (master). It's merged in my develop. It would force me drop support to many old Android devices (particularly, Anrdoid 6 and 7 which are still popular enough to keep me interested supporting them).

  • STEP Bible's fork is way behind this repository and also is way ahead of it. The suggested pull requests do not apply cleanly. It'll take much effort to bring them into harmony.

I have once (not very recently though) merged their stuff so if you merge my branch you should get most (if not all) from STEP too.

@UnasZole
Copy link
Author

@dmsmith I'm really happy to know that you are back, and willing to take this repo back on track !
I tried to offer my help to rejuvenate it almost a year ago (see this mailing list thread : http://crosswire.org/pipermail/sword-devel/2024-February/049937.html ) but I discovered that there is a lot of... inertia for such changes. 😆
I didn't even get confirmation of who had admin rights on this repository and project.

Let me know if I can help you in any way to make this repository up to date and usable again !

@dmsmith
Copy link
Contributor

dmsmith commented Jan 14, 2025

@UnasZole I'm spending a couple of hours each day trying to wrap my head around the mechanics of doing it and what the impact might be. I'll post to jsword-devel soon to see what kind of inertia, as you say, we might have and try to work out a collaboration to get it done. Your help is welcomed when we get rolling.

@dmsmith
Copy link
Contributor

dmsmith commented Jan 15, 2025

@dmsmith I'm really happy to know that you are back, and willing to take this repo back on track ! I tried to offer my help to rejuvenate it almost a year ago (see this mailing list thread : http://crosswire.org/pipermail/sword-devel/2024-February/049937.html ) but I discovered that there is a lot of... inertia for such changes. 😆 I didn't even get confirmation of who had admin rights on this repository and project.

Let me know if I can help you in any way to make this repository up to date and usable again !

So I read the thread. I had missed it because it was on sword-level and not on jsword-devel.
You have lots of great ideas.

I just posted to jsword-devel regarding "reviving" this master repository. Basic idea, a small number of core developers from AndBible and STEPBible are added as committers to this repository. If there are other major development efforts, we'd entertain their inclusion. Want to keep it small to act as gate keepers. While I have a vested interest in JSword as its principal architect, I have not been a good steward of changes in the last 10 years. Realistically, I have the time now, being retired, but I think it needs to be sustainable without me.

Regarding OSIS, David Haslam and I have taken ownership of it in a practical sense. He and I have maintained the KJV at CrossWire and needed changes in it. We discovered that it is a dead specification in every practical sense and your thread discussed that fully.

From a JSword perspective, OSIS is the center of how modules are handled. Every module content is converted to OSIS and then that is displayed via xslt in HTML.

From a CrossWire perspective, JSword is to implement all the changes of the SWORD C++ library as it regards files (books and configuration files). As SWORD has hardcoded versifications, JSword considers those to be files. There may be other things in SWORD which JSword should match such as the ability to read a file and convert it to a module.

@dmsmith
Copy link
Contributor

dmsmith commented Jan 24, 2025

Closing as answered.

@dmsmith dmsmith closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants