Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video panning #3

Open
wants to merge 25 commits into
base: mod
Choose a base branch
from
Open

Video panning #3

wants to merge 25 commits into from

Commits on Feb 20, 2023

  1. Add video panning

    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    6285e4e View commit details
    Browse the repository at this point in the history

  2. Add menu item for resetting the video pan

    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    4b59099 View commit details
    Browse the repository at this point in the history

  3. Change tab to spaces

    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    51dafe2 View commit details
    Browse the repository at this point in the history

  4. Fix mouse position bug when videoAr > displayAr 

    Crosshair drawing is broken when videoAr != displayAr
    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    d78dace View commit details
    Browse the repository at this point in the history

  5. Fix crosshair drawing 

    I'm not sure about that scale_factor, i don't know how to test that
    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    bb65a63 View commit details
    Browse the repository at this point in the history

  6. Change pan values with the zoom level changes

    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    41d8819 View commit details
    Browse the repository at this point in the history

  7. Respect min. zoom value when changing pan coords

    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    da7154b View commit details
    Browse the repository at this point in the history

  8. Make video zoom different from preview window zoom

    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    b385aa0 View commit details
    Browse the repository at this point in the history

  9. Make zooming center around the cursor position

    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    b953c92 View commit details
    Browse the repository at this point in the history

  10. Make zooming feel more linear 

    with a "good enough" implementation
    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    1c3c9e3 View commit details
    Browse the repository at this point in the history

  11. Fix a zooming bug on linux 

    The preview window would change in width, when the video was being zoomed.
Possibly, because on windows, zooming only calls UpdateSize once, but on
linux, it gets called multiple, like 8 times.
Rounding fixed it.
    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    57883bf View commit details
    Browse the repository at this point in the history

  12. Add reset hotkey as Ctrl-R 

    I'm not entirely sure, that this is how it's supposed to be added.
This requires editing the already existing hotkey.json file (shows path
in log, if it exists).
Should this also be added to hotkey.cpp?
    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    b2dd7fe View commit details
    Browse the repository at this point in the history

  13. Revert "Add reset hotkey as Ctrl-R" / Not needed 

    This reverts commit 3d525d9.
The default hotkey is not required. People can just add a custom one
from the hotkey settings if they want this.
    @moex3 @MIRIMIRIM
    moex3 authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    e8a19fd View commit details
    Browse the repository at this point in the history

  14. Added option to enable video panning

    @Sodra @MIRIMIRIM
    Sodra authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    66e0a1d View commit details
    Browse the repository at this point in the history

  15. Fix video panning option. Oops teehee ptep~

    @Sodra @MIRIMIRIM
    Sodra authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    7bdad68 View commit details
    Browse the repository at this point in the history

  16. Fixing zoom when panning is off

    @Sodra @MIRIMIRIM
    Sodra authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    3308161 View commit details
    Browse the repository at this point in the history

  17. Also add Video Pan option on OSX

    @arch1t3cht @MIRIMIRIM
    arch1t3cht authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    527b838 View commit details
    Browse the repository at this point in the history

  18. Add option toggling behaviour of Ctrl+Zoom

    @arch1t3cht @MIRIMIRIM
    arch1t3cht authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    6287089 View commit details
    Browse the repository at this point in the history

  19. Add options to commit or reverse video zoom

    @arch1t3cht @MIRIMIRIM
    arch1t3cht authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    935d546 View commit details
    Browse the repository at this point in the history

  20. video zoom: Fix aspect ratio forcing 

    Do this by partially reverting the changes to UpdateSize in favor of
just multiplying by videoZoomValue *after* setting all the window sizes.
    @arch1t3cht @MIRIMIRIM
    arch1t3cht authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    d673f0a View commit details
    Browse the repository at this point in the history

  21. video zoom: Fix visual tools with DPI scaling

    @arch1t3cht @MIRIMIRIM
    arch1t3cht authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    c85e5d2 View commit details
    Browse the repository at this point in the history

  22. video zoom: Fix detached video with DPI scaling

    @arch1t3cht @MIRIMIRIM
    arch1t3cht authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    7eb7eb7 View commit details
    Browse the repository at this point in the history

  23. video zoom: Fix crash on windows when making detached video too small

    @arch1t3cht @MIRIMIRIM
    arch1t3cht authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    7ab5bf0 View commit details
    Browse the repository at this point in the history

  24. Remove "Video Panning" option 

    It's probably stable enough at this point, and hiding it behind an
option just creates more confusion than it prevents.
    @arch1t3cht @MIRIMIRIM
    arch1t3cht authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    1593b9d View commit details
    Browse the repository at this point in the history

  25. video zoom: Fix zoom when script_res != video_res

    @arch1t3cht @MIRIMIRIM
    arch1t3cht authored and MIRIMIRIM committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    0d6fc11 View commit details
    Browse the repository at this point in the history