Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve warnings against missing array keys in Button #1736

Merged
merged 9 commits into from
Nov 4, 2024
Merged

fix: Resolve warnings against missing array keys in Button #1736

merged 9 commits into from
Nov 4, 2024

Commits on Nov 1, 2024

  1. Always give icon a key

    @dlnr
    dlnr committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    9659b95 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Update packages/react/src/Button/Button.tsx

    @VincentSmedinga
    VincentSmedinga authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ae2da82 View commit details
    Browse the repository at this point in the history

  2. Choose fragments over arrays and keys

    @VincentSmedinga
    VincentSmedinga committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1a0106d View commit details
    Browse the repository at this point in the history

  3. Remove another key

    @VincentSmedinga
    VincentSmedinga committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    193b257 View commit details
    Browse the repository at this point in the history

  4. Remove explicit ‘true’

    @VincentSmedinga
    VincentSmedinga committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bd7fd38 View commit details
    Browse the repository at this point in the history

  5. Conclude that inline conditions are simplest anyway

    @VincentSmedinga
    VincentSmedinga committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f79b546 View commit details
    Browse the repository at this point in the history

  6. Fix condition

    @VincentSmedinga
    VincentSmedinga committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    711b1be View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into fix/1732-error-on-icon-prop

    @VincentSmedinga
    VincentSmedinga authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c943835 View commit details
    Browse the repository at this point in the history

  8. Fix another condition

    @VincentSmedinga
    VincentSmedinga committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1ffb676 View commit details
    Browse the repository at this point in the history