fix: Resolve warnings against missing array keys in Button #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-1732-error-on-icon-prop
VincentSmedinga
changed the title
VincentSmedinga
previously approved these changes
Nov 4, 2024
github-actions
bot
temporarily deployed
to
demo-1732-error-on-icon-prop
github-actions
bot
temporarily deployed
to
demo-1732-error-on-icon-prop
github-actions
bot
temporarily deployed
to
demo-1732-error-on-icon-prop
VincentSmedinga
changed the title
github-actions
bot
temporarily deployed
to
demo-1732-error-on-icon-prop
github-actions
bot
temporarily deployed
to
demo-1732-error-on-icon-prop
github-actions
bot
temporarily deployed
to
demo-1732-error-on-icon-prop
alimpens
approved these changes
Nov 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
The content function with a switch produces children without a key.
Why
To prevent an error.
How
Added key to single child which should not be needed, It must have something to do with the wrapping content function that produces content as a Reactnode.Ended up restoring an earlier approach with multiple conditions in the render function, which doesn’t even need any keys.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes