-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve headings and guidelines throughout documentation #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
changed the title
chore: Improve headings on all documentation pages
chore: Improve headings and guidelines on all documentation pages
Sep 3, 2024
VincentSmedinga
changed the title
chore: Improve headings and guidelines on all documentation pages
chore: Improve headings and guidelines throughout documentation
Sep 3, 2024
dlnr
previously approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotta love consistency.
alimpens
reviewed
Sep 4, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-sentence-case-for-headings
September 4, 2024 11:22
Destroyed
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-sentence-case-for-headings
September 4, 2024 11:57
Destroyed
github-actions
bot
temporarily deployed
to
demo-sentence-case-for-headings
September 4, 2024 12:09
Destroyed
alimpens
approved these changes
Sep 4, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What
as
propWhy
The main goal was to stop using ‘Title Case’ in headings, even though it introduces a difference with the table of contents that Storybook generates, and to put the ‘Examples’ heading in the correct place for all components.
How
Manually :)
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes