-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Hint as component and Label and FieldSet props #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/DES-844-form-field-not-required
…ES-844-form-field-not-required
…t/DES-844-form-field-not-required
alimpens
reviewed
Aug 14, 2024
alimpens
reviewed
Aug 14, 2024
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
August 30, 2024 14:50
Destroyed
…ES-844-form-field-not-required
…t/DES-844-form-field-not-required
…terdam/design-system into feat/DES-844-form-field-not-required
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 4, 2024 07:19
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 4, 2024 07:28
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 4, 2024 15:03
Destroyed
…t/DES-844-form-field-not-required
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 5, 2024 08:06
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 18, 2024 06:52
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 18, 2024 07:02
Destroyed
alimpens
reviewed
Sep 18, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 18, 2024 12:17
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 18, 2024 12:29
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 18, 2024 12:32
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 18, 2024 12:34
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 18, 2024 12:38
Destroyed
…t/DES-844-form-field-not-required
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 18, 2024 14:37
Destroyed
alimpens
reviewed
Sep 20, 2024
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 20, 2024 08:09
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 20, 2024 08:37
Destroyed
alimpens
reviewed
Sep 20, 2024
…terdam/design-system into feat/DES-844-form-field-not-required
github-actions
bot
temporarily deployed
to
demo-DES-844-form-field-not-required
September 20, 2024 09:14
Destroyed
alimpens
approved these changes
Sep 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Mark form fields as not required.
What
Adds text to a label or a field set's legend if the form element (input, field set, etc.) is explicitly marked as not required. The text communicates that the field is not required for submission of the form.
Why
There needs to be a way to communicate to end-users what form fields are not required.
How
Properties are added to Label and Field Set to set them as required. The values should be the same as the associated
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes