Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve audio #46

Merged
merged 4 commits into from
Dec 28, 2024

More accurate timing emulation by using decimal values

cc786f2
Select commit
Loading
Failed to load commit list.
Merged

Improve audio #46

More accurate timing emulation by using decimal values
cc786f2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 28, 2024 in 0s

82.17% (+0.35%) compared to a89b8dc

View this Pull Request on Codecov

82.17% (+0.35%) compared to a89b8dc

Details

Codecov Report

Attention: Patch coverage is 88.88889% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (a89b8dc) to head (cc786f2).

Files with missing lines Patch % Lines
plastic_core/src/apu2a03/channel.rs 91.17% 3 Missing ⚠️
plastic_core/src/apu2a03/mod.rs 88.88% 2 Missing ⚠️
plastic_core/src/misc.rs 0.00% 1 Missing ⚠️
plastic_core/src/nes.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   81.81%   82.17%   +0.35%     
==========================================
  Files          37       37              
  Lines        5352     5312      -40     
==========================================
- Hits         4379     4365      -14     
+ Misses        973      947      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.