Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve audio #46

Merged
merged 4 commits into from
Dec 28, 2024
Merged

Improve audio #46

merged 4 commits into from
Dec 28, 2024

Conversation

Amjad50
Copy link
Owner

@Amjad50 Amjad50 commented Dec 28, 2024

Partial fix for #9

General improvement for audio quality.

  • Emulator uses a Digital-Analog-Converter (DAC) simulation to improve audio emulation quality.
  • Emulator returns Stereo audio now (NES is mono, so its just copy of the same channel 2 times).
  • Other code fixes.

There are still some emulation inaccuracies, for example in SMB2, when jumping the audio is being cut short for some reason.
This will require more work

Signed-off-by: Amjad Alsharafi <[email protected]>
Using counter allows us to use decimal values for the
`CPU_CYCLES_PER_FRAME` number.

Signed-off-by: Amjad Alsharafi <[email protected]>
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (a89b8dc) to head (cc786f2).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
plastic_core/src/apu2a03/channel.rs 91.17% 3 Missing ⚠️
plastic_core/src/apu2a03/mod.rs 88.88% 2 Missing ⚠️
plastic_core/src/misc.rs 0.00% 1 Missing ⚠️
plastic_core/src/nes.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   81.81%   82.17%   +0.35%     
==========================================
  Files          37       37              
  Lines        5352     5312      -40     
==========================================
- Hits         4379     4365      -14     
+ Misses        973      947      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amjad50 Amjad50 enabled auto-merge December 28, 2024 04:48
@Amjad50 Amjad50 merged commit ef0cc31 into master Dec 28, 2024
4 checks passed
@Amjad50 Amjad50 deleted the improve_audio branch December 28, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant