Issue #336 Multi-chain support - run a second instance of ganache-cli with Chain Id #1 #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elpiel
commented
Mar 28, 2022
elpiel
commented
- scripts - ethereum - Dockerfile - add CHAIN_ID env. var
- scripts - ethereum - add snapshot_contracts_{CHAIN_ID} snapshots
- scropts - ethereum - ganache-cli - use CHAIN_ID env. var.
- docker-compose.harness.yml - run second instance of ganache-cli
- test_harness - Makefile - start second ganache-cli service
- test_harness - add deployment for contracts on second chain
- test_harness - Setup - add logger & logging
- scripts - ethereum - Dockerfile add CHAIN_ID env. var
- scripts - ethereum - add snapshot_contracts_{CHAIN_ID} snapshots
- scropts - ethereum - ganache-cli - use CHAIN_ID env. var.
- docker-compose.harness.yml - run second instance of ganache-cli
- test_harness - Makefile - start second ganache-cli service
- test_harness - add deployment for contracts on second chain
- test_harness - Setup - add logger & logging
scripts - ethereum - use snapshot folder based on CHAIN_ID
elpiel
commented
Mar 29, 2022
| @@ -28,7 +29,7 @@ pub mod deposits; | |||
| /// NOTE: Current the snapshot and test setup use a single Chain. | |||
| /// | |||
| /// Uses Chain #1337 from the [`GANACHE_CONFIG`] static to init the contracts | |||
| pub static SNAPSHOT_CONTRACTS: Lazy<Contracts> = Lazy::new(|| { | |||
| pub static SNAPSHOT_CONTRACTS_1337: Lazy<Contracts> = Lazy::new(|| { | |||
There was a problem hiding this comment.
We should think of better way to setup and test when using multi-chain. This is sufficient for the time being.
elpiel
commented
Mar 29, 2022
| # The Chain Id that will be passed to `ganache-cli` | ||
| ENV CHAIN_ID= | ||
| # The snapshot contracts directory that will be used | ||
| ARG SNAPSHOT_CONTRACTS= |
There was a problem hiding this comment.
Env. variables cannot be used in COPY, this is why we are passing a build argument of the snapshot directory that will be loaded by Ganache-cli
simzzz
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.