Analytics routes #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

elpiel merged 27 commits into aip-61-adex-v5 from analytics-routes

Jan 18, 2022

Contributor

simzzz commented Nov 29, 2021 •

edited

Loading

To-Do:

Discuss if we are going to just leave query start/end fields to be milliseconds

simzzz added 3 commits

November 23, 2021 18:13


          initial progress

d91948e


          Merge branch 'aip-61-adex-v5' into analytics-routes


          initial implementation for analytics v5 routes finished

cbc4cd6

simzzz requested a review from elpiel

November 29, 2021 14:40


          code clean up

c1e90a0

elpiel requested changes

View reviewed changes

docs/config/ganache.toml Outdated Show resolved Hide resolved

primitives/src/analytics.rs Outdated Show resolved Hide resolved

primitives/src/sentry.rs Outdated Show resolved Hide resolved

sentry/src/db/analytics.rs Outdated Show resolved Hide resolved

sentry/src/db/analytics.rs Outdated Show resolved Hide resolved

sentry/src/db/analytics.rs Outdated Show resolved Hide resolved

elpiel reviewed

View reviewed changes

primitives/src/analytics.rs Outdated Show resolved Hide resolved

elpiel reviewed

View reviewed changes

primitives/src/analytics.rs Outdated Show resolved Hide resolved

elpiel reviewed

View reviewed changes

primitives/src/analytics.rs Outdated Show resolved Hide resolved

elpiel reviewed

View reviewed changes

primitives/src/analytics.rs Outdated Show resolved Hide resolved

elpiel requested changes

View reviewed changes

primitives/src/analytics.rs Outdated Show resolved Hide resolved

simzzz and others added 17 commits

December 3, 2021 22:25


          (still WIP) requested changes + test coverage

e10ceaa


          modified output + output is now split by timeframe

00397f6


          primitives - analytics - rename_all=camelCase

5be038a


          improved query, small changes to logic

150b1dd


          Merge branch 'analytics-routes' of https://github.com/AmbireTech/adex…

…-validator-stack-rust into analytics-routes


          improvements on analytics

989f66d


          fix impl Display for DateHour

fb6c8cf


          analytics query can now accept both timestamps and date strings

dc97852


          tests almost ready + changes to logic

526b708


          Additional tests

381533d


          test progress

743c1c3


          fixed failing tests and logic + added myself as author

e11962f


          output is represented correctly + other minor changes

35942fb


          Cargo - patch postgres-types

38ccc03


          primitives - senty:

69a2448

- FetchedAnalytics - use DateTime
- test impl DateHour - &Timeframe


          Cargo patch postgres-types:

96fec64

Use new branch `from-T-for-boxed-dyn-ToSql`


          primitives - analytics - enum AllowedKeys & struct Time

8e842ee

Member

elpiel commented Dec 31, 2021 •

edited

Loading

TODOs:

Check (aka test) impls for Ord, PartialOrd, PartialEq for DateHour
More tests for query::Time
Deserialize DateHour from either timestamp or ISO format
Caching analytics (if needed)


          adapter - fix dummy warning

1fea534

elpiel added 2 commits

January 10, 2022 09:24


          Analytics changes:

7d6a276

- primitives - DateHour - PartialEq/PartialOrd
- primitives - AllowedKey impls & use Time
- sentry - migrations - rename column `os` to `os_name`
- sentry - db - analytics - improve SQL query and prepare testing


          sentry - Event improvements & new enum EventType

04fe52b

elpiel mentioned this pull request

AIP #61 v5: Channel and Campaign #382

Closed

21 tasks

elpiel added 3 commits

January 17, 2022 13:07


          sentry - db - analytics testing:

69f4acf

- Use primitives::sentry::EventType in structs
- Use primitives::analytics::FetchedMetric
- primitives::UnifiedNum - add Mul impls for u64
- sentry - db - analytics - finish query & testing


          sentry - routes - analytics - finish route & tests

7e8d449


          Merge branch 'aip-61-adex-v5' into analytics-routes

b647999

Contributor Author

simzzz commented Jan 17, 2022

LGTM, I think the changes reduce the complexity of the logic we had in some places.

elpiel approved these changes

View reviewed changes

elpiel merged commit b6344f3 into aip-61-adex-v5

Member

elpiel commented Jan 18, 2022

TODOs:

* [x]  Check (aka test) impls for Ord, PartialOrd, PartialEq for DateHour

* [x]  More tests for `query::Time`

* [ ]  Deserialize DateHour from either timestamp or ISO format

* [ ]  Caching analytics (if needed)

I'm moving the last 2 TODOs to the #382 issue, these can be implemented on later stage.

elpiel deleted the analytics-routes branch

January 18, 2022 12:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet