Skip to content

Issue 382 Remove V4 Channel and fns cleanup #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 28, 2021

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Sep 24, 2021

Completes a task in #382

  • Clean up V4 Channel and other routes & functions
  • Config preparation for v5
  • Ethereum adapter - remove old tokio compat crate

- primitives - remove V4 Channel
- Config - remove unused values & add update with analytics
- sentry - remove old V4 Channel routes
@elpiel elpiel mentioned this pull request Sep 24, 2021
21 tasks
@elpiel elpiel requested review from simzzz and removed request for simzzz September 24, 2021 12:11
- Adapter & error imporvements in adapters
@elpiel elpiel changed the title Issue 382 old V4 Channel and fns cleanup Issue 382 Remove V4 Channel and fns cleanup Sep 24, 2021
- adapter - remove tokio-compat-02
- primitives - move once_cell from dev deps to deps
- use once_cell::sync::Lazy
- fix typo in config attribute
@elpiel elpiel force-pushed the issue-382-old-channel-and-fns-cleanup branch from 3459c11 to 9694de8 Compare September 27, 2021 08:25
@elpiel elpiel marked this pull request as ready for review September 27, 2021 09:24
@elpiel elpiel requested a review from simzzz September 27, 2021 10:12
Copy link
Contributor

@simzzz simzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a few use statements and function names that could be changed

@elpiel elpiel force-pushed the issue-382-old-channel-and-fns-cleanup branch from dcac2b3 to b32d221 Compare September 28, 2021 06:51
@elpiel elpiel requested a review from simzzz September 28, 2021 06:52
@elpiel elpiel merged commit 20e123e into aip-61-adex-v5 Sep 28, 2021
@elpiel elpiel deleted the issue-382-old-channel-and-fns-cleanup branch September 28, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants