AIP#61 AdEx V5: Targeting rules use UnifiedNum #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- re-export mod prefix_active - replace BigNum usage with UnifiedNum
- add more helper methods - Change Debug impl to show the float representation
4 tasks
elpiel
changed the title
elpiel
commented
Jun 18, 2021
| @@ -234,7 +234,7 @@ pub fn get_unit_html_with_events( | |||
| .map(|validator| { | |||
| let fetch_url = format!( | |||
| "{}/channel/{}/events?pubAddr={}", | |||
There was a problem hiding this comment.
This will be fixed when the events route for a Campaign is updated, see tasks for #382
simzzz
reviewed
Jun 23, 2021
simzzz
approved these changes
Jun 24, 2021
samparsky
approved these changes
Jun 25, 2021
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.