Skip to content

AdEx v5: Issue #382 Channel and Campaign #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 18, 2021

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Mar 15, 2021

This PR tackles some of the changes required for #382.

Changelog:

Introduces the new structs & enums for AdEx v5:

  • primitives::campaign::{Campaign, Validators, Active, etc.}
  • primitives::channel_v5::Channel (should replace the channel module which has the v4 Channel)
    • implemented fn id(&self) -> ChannelId
    • primitives::channel_v5::Nonce - a U256 with a string (de)serializatoin instead of hex
  • Address - should replace all the instances of ValidatorId where the ValidatorId is used for an Address (token address, contract address, spender, earner, etc.)
  • primitives::ToHex - trait for encoding values to 0x prefixed or non-prefixed Strings
  • primitives::eth_checksum - now uses tiny_keccak
  • Cargo - primitives:
    • Updated tiny_keccak to 2.0
    • Removed rust-crypto dependency
    • Updated num to 0.4 and use the feature num-bigint
    • Removed num-bigint dependency
  • Cargo - validator_worker:
    • Updated num to 0.4

@elpiel elpiel changed the title Issue #382 Channel and Campaign v5: Issue #382 Channel and Campaign Mar 15, 2021
@elpiel elpiel changed the title v5: Issue #382 Channel and Campaign AdEx v5: Issue #382 Channel and Campaign Mar 15, 2021
@elpiel elpiel requested review from samparsky and simzzz March 16, 2021 06:35
@elpiel elpiel force-pushed the issue-382-channel-and-campaign branch from 2d1ed36 to 7ea437b Compare March 16, 2021 15:47
@elpiel elpiel requested a review from samparsky March 16, 2021 15:47
@elpiel elpiel added the primitives Changes regarding the `primitives` crate label Mar 18, 2021
@elpiel elpiel merged commit 9c76970 into aip-61-adex-v5 Mar 18, 2021
@elpiel elpiel deleted the issue-382-channel-and-campaign branch March 19, 2021 09:46
@elpiel elpiel mentioned this pull request Apr 6, 2021
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
primitives Changes regarding the `primitives` crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants