-
Notifications
You must be signed in to change notification settings - Fork 10
AdEx v5: Issue #382 Channel and Campaign #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
samparsky
suggested changes
Mar 16, 2021
2d1ed36
to
7ea437b
Compare
simzzz
approved these changes
Mar 17, 2021
samparsky
approved these changes
Mar 18, 2021
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles some of the changes required for #382.
Changelog:
Introduces the new structs & enums for AdEx v5:
primitives::campaign::{Campaign, Validators, Active, etc.}
primitives::channel_v5::Channel
(should replace thechannel
module which has the v4Channel
)fn id(&self) -> ChannelId
primitives::channel_v5::Nonce
- aU256
with a string (de)serializatoin instead of hexAddress
- should replace all the instances ofValidatorId
where theValidatorId
is used for an Address (token address, contract address, spender, earner, etc.)primitives::ToHex
- trait for encoding values to0x
prefixed or non-prefixedStrings
primitives::eth_checksum
- now usestiny_keccak
primitives
:tiny_keccak
to2.0
rust-crypto
dependencynum
to0.4
and use the featurenum-bigint
num-bigint
dependencyvalidator_worker
:num
to0.4