Adds confirm to response of legacy overview #442
Conversation
📝 WalkthroughWalkthroughThe pull request introduces a new nullable Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (2)src/Altinn.Correspondence.API/Mappers/LegacyCorrespondenceOverviewMapper.cs (1)
The addition of the Let's verify that the property types match between the source and destination models: ✅ Verification successfulLet me try a different approach to verify the property types by searching for the class definitions directly. Let me fix the regex and search for the Confirmed property in both classes, including the base class: Let me try one final search with escaped characters: Property types are consistent, mapping is correct The verification confirms that both the source and destination models have the
The direct mapping in the mapper is appropriate given the matching types. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify property type consistency between models
# Expected: Both properties should be of type DateTimeOffset?
# Check source model (LegacyGetCorrespondenceOverviewResponse)
echo "Checking source model:"
ast-grep --pattern 'class LegacyGetCorrespondenceOverviewResponse {
$$$
Confirmed $_
$$$
}'
# Check destination model (LegacyCorrespondenceOverviewExt)
echo "Checking destination model:"
ast-grep --pattern 'class LegacyCorrespondenceOverviewExt {
$$$
Confirmed $_
$$$
}'
Length of output: 311 Script: #!/bin/bash
# Search for class definitions and their Confirmed property
echo "Searching for LegacyGetCorrespondenceOverviewResponse:"
rg -A 10 "class LegacyGetCorrespondenceOverviewResponse"
echo -e "\nSearching for LegacyCorrespondenceOverviewExt:"
rg -A 10 "class LegacyCorrespondenceOverviewExt"
# Also search for any Confirmed property declarations to catch if defined elsewhere
echo -e "\nSearching for Confirmed property declarations:"
rg "public \w+\??\s+Confirmed\s*{\s*get;"
Length of output: 3512 Script: #!/bin/bash
# Search for Confirmed property declarations with fixed regex
echo "Searching for Confirmed property declarations:"
rg "public.*Confirmed.*{.*get"
# Check the base class CorrespondenceOverviewExt since LegacyCorrespondenceOverviewExt inherits from it
echo -e "\nChecking base class CorrespondenceOverviewExt:"
rg -A 15 "class CorrespondenceOverviewExt"
Length of output: 2025 Script: #!/bin/bash
# Search for Confirmed property with properly escaped regex
echo "Searching for Confirmed property in all models:"
rg "public\s+\w+[\?\s]+Confirmed\s*\{\s*get"
# Also check the BaseCorrespondenceExt class since CorrespondenceOverviewExt inherits from it
echo -e "\nChecking BaseCorrespondenceExt class:"
rg -A 15 "class BaseCorrespondenceExt"
Length of output: 2259 src/Altinn.Correspondence.API/Models/LegacyCorrespondenceOverviewExt.cs (1)
The new Let's verify if any validation attributes are used on similar timestamp properties in other model classes: ✅ Verification successfulLGTM! The implementation follows established patterns and no validation attributes are needed. Looking at all DateTimeOffset properties across the Models directory, I can confirm that:
Since 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if validation attributes are used on DateTimeOffset properties in model classes
# Expected: Find any validation patterns we should follow
# Search for DateTimeOffset property declarations in model classes
rg -g "*/Models/*.cs" "DateTimeOffset.*{.*get.*set" -A 2
Length of output: 185 Script: #!/bin/bash
# Description: Check if validation attributes are used on DateTimeOffset properties in model classes
# Expected: Find any validation patterns we should follow
# Search for DateTimeOffset property declarations in model classes
rg -g "*/Models/*.cs" "DateTimeOffset" -B 2 -A 2
# Also search specifically for validation attributes on properties
rg -g "*/Models/*.cs" "\[.*Validation.*\]" -B 2 -A 2
Length of output: 401 Script: #!/bin/bash
# Description: Check if validation attributes are used on DateTimeOffset properties in model classes
# Expected: Find any validation patterns we should follow
# First, let's find all .cs files in Models directories
fd "\.cs$" --full-path "*/Models"
# Then search for DateTimeOffset properties in those files
fd "\.cs$" --full-path "*/Models" --exec grep -B 2 -A 2 "DateTimeOffset"
# And search for validation attributes
fd "\.cs$" --full-path "*/Models" --exec grep -B 2 -A 2 "\[.*Validation"
Length of output: 471 Script: #!/bin/bash
# Description: Check if validation attributes are used on DateTimeOffset properties in model classes
# Expected: Find any validation patterns we should follow
# Find all .cs files in Models directories
find . -type f -path "*/Models/*.cs" -exec grep -B 2 -A 2 "DateTimeOffset" {} \;
# Search for validation attributes in model classes
find . -type f -path "*/Models/*.cs" -exec grep -B 2 -A 2 "\[.*Validation" {} \;
Length of output: 5565 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Andreass2
added
kind/bug
Description
Related Issue(s)
Verification
Documentation
Summary by CodeRabbit
Confirmedproperty to the correspondence overview, allowing users to see the confirmation status of correspondence.DateTimeOffsetproperty for the confirmation date, enhancing the data representation for users.