fix legacy tests

[Andreass2]

Description

Fix a small error in legacy test

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

• Tests
  • Updated assertions in correspondence history tests to handle PartyId as an integer instead of a string, enhancing validation accuracy.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in the LegacyControllerTests.cs file focus on updating the assertions related to the PartyId in the context of correspondence history tests. The assertion method was modified to compare PartyId as an integer instead of a string. No changes were made to method signatures or the overall structure of the test class, which continues to validate various scenarios of the legacy correspondence API.

Changes

File	Change Summary
Test/Altinn.Correspondence.Tests/LegacyControllerTests.cs	Updated assertions to compare PartyId as an integer instead of a string; no structural changes.

Possibly related PRs

• Change legacy to use altinn token instead of maskinporten token #367: Changes to the legacy controller's authentication mechanism may relate to PartyId handling.
• Legacy - authorize multiple recipients #388: Enhancements to authorization processes could be relevant to PartyId validation changes.
• fix correct userparty #402: Modifications in handling user party IDs align with PartyId assertion updates.
• Add message sender to Legacy list request #409: Addition of properties related to correspondence items may connect with PartyId validation.
• Feat: LegacyController - Add LegacyGetCorrespondenceHistory #413: Introduction of a method for retrieving correspondence history could relate to PartyId validation.
• Fix: Ensure correspondence is fetched before updating to Read or Confirmed #427: Enhanced validation logic for correspondence status updates may be relevant to assertion changes.
• Adds confirm to response of legacy overview #442: Confirmation features in correspondence responses could relate to PartyId validation.
• fix: use correct lookupParty function, change onbehalfofpartyId to int #444: Changes regarding the onBehalfOfPartyId type may connect with PartyId updates.
• LegacyController: Add UpdateCorrespondenceStatusHandler for Confirm and Archive #447: New methods for confirming and archiving correspondence may relate to PartyId history validation.
• Add markasread functionality to LegacyController #474: Implementation of markasread functionality may connect with correspondence status validation.
• Tests for Correspondence list #481: Enhancements in testing for correspondence functionality may relate to PartyId assertion updates.
• Legacy: minor fixes in GetHistory & UpdateStatus #483: Minor fixes in GetHistory and UpdateStatus functionalities may connect with PartyId validation changes.

Suggested labels

kind/bug, ignore-for-release

Suggested reviewers

• CelineTrammi

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2cae593 and d764a99.

📒 Files selected for processing (1)

• Test/Altinn.Correspondence.Tests/LegacyControllerTests.cs (1 hunks)

🔇 Additional comments (1)

Test/Altinn.Correspondence.Tests/LegacyControllerTests.cs (1)

158-158: LGTM! Improved type safety in PartyId comparison.

The change from string comparison to integer comparison for PartyId is correct and improves type safety. This fix ensures that we're comparing values of the same type without unnecessary string conversion.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.