Feat: Filter matching events in reverse order #6485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
reviewed
Jan 27, 2025
| @@ -378,6 +379,7 @@ def get_matching_events( | |||
| end_date: Filter events before this date (ISO format) | |||
| start_id: Starting ID in the event stream. Defaults to 0 | |||
| limit: Maximum number of events to return. Must be between 1 and 100. Defaults to 100 | |||
| reverse: Whether to retrieve events in reverse order. Defaults to False. | |||
|
|
|||
| Returns: | |||
| list: List of matching events (as dicts) | |||
There was a problem hiding this comment.
Not necessarily for this PR, but just a thought since we're looking at this: I'm not sure why we return dicts. It seems it would make sense to return events.
The FE-related methods are able to convert I think, and that would make this method potentially more useful in the backend too (which works with events usually, not with dicts)
There was a problem hiding this comment.
Yeah I thought about the same thing; I'll look into this further...
This was referenced Jan 28, 2025
zchn
pushed a commit
to zchn/OpenHands
that referenced
this pull request
Feb 4, 2025
idagelic
pushed a commit
to idagelic/OpenHands
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
Adds option to traverse events in reverse when filtering matching criteria
Link of any specific issues this addresses
To run this PR locally, use the following command: