Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Don't serialize matching events when searching event stream #6509

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

malhotra5
Copy link
Contributor

@malhotra5 malhotra5 commented Jan 28, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR implements a fix to a NIT introduced in #6485. The get_matching_events function should return a list of Event instead of its serialized format.


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:3d0fded-nikolaik   --name openhands-app-3d0fded   docker.all-hands.dev/all-hands-ai/openhands:3d0fded

@malhotra5 malhotra5 requested a review from enyst January 28, 2025 22:28
Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it makes sense!

@malhotra5 malhotra5 merged commit eb760f3 into main Jan 28, 2025
14 checks passed
@malhotra5 malhotra5 deleted the fix/matching-events-return-types branch January 28, 2025 23:17
@malhotra5 malhotra5 mentioned this pull request Jan 28, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants