[Bug][Resolver]: Multiline comments crashing resolver #5641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
Summary
There is a bug where comments with quotations or multi-line comments caused the resolver to crash. This is because we were using bash to check the event body for "openhands-agent` macro, but the event body string was not properly escaped.
In this PR, we've opted to move away from bash and use javascript instead to implement the same functionality.
Alternatives considered but opted against
if [[ "$(echo '${{ github.event.comment.body }}' | tr -d '\n' | sed "s/'/'\\\\''/g")" == "@openhands-agent-exp"* ]]; then
)a. Opted against this as readability becomes tough and the expression needs to be used in multiple places
a. Opted against this as it would bloat the workflow with too many steps
Sample Test
Example workflow logs
Link of any specific issues this addresses
#5230
To run this PR locally, use the following command: