Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Resolver fails to "Install OpenHands" when tagged with @openhands-agent on a comment on an PR without the "fix-me" #5621

Closed
1 task done
oconnorjoseph opened this issue Dec 16, 2024 · 7 comments
Labels
bug Something isn't working resolver Related to OpenHands Resolver

Comments

@oconnorjoseph
Copy link
Contributor

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

When the user tags @openhands-agent without a fix-me tag in the PR, the Resolver will leave a comment on the PR as if it will fix the issue. But it runs into the following error on the "Install OpenHands" job:

Run if [[ "" == "fix-me-experimental" ]] ||
/home/runner/work/_temp/4b187817-0de6-48c1-a0f0-cd08f3e6d9ce.sh: line 3: conditional binary operator expected
Error: Process completed with exit code 2.

Perhaps this error should be handled more gracefully, or the user should be able to tag the agent on PRs without the fix-me tag.

OpenHands Installation

Docker command in README

OpenHands Version

0.15.2

Operating System

Linux

Logs, Errors, Screenshots, and Additional Context

Run if [[ "" == "fix-me-experimental" ]] ||
/home/runner/work/_temp/4b187817-0de6-48c1-a0f0-cd08f3e6d9ce.sh: line 3: conditional binary operator expected
Error: Process completed with exit code 2.
@oconnorjoseph oconnorjoseph added the bug Something isn't working label Dec 16, 2024
@oconnorjoseph
Copy link
Contributor Author

oconnorjoseph commented Dec 16, 2024

This actually happen for GitHub Issues too. It appears to be happening for anytime you prompt @openhands-agent via a GitHub comment.

@enyst
Copy link
Collaborator

enyst commented Dec 16, 2024

@openhands-agent-exp what do you think?

@openhands-agent
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

@openhands-agent
Copy link
Contributor

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-5621' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

@malhotra5
Copy link
Contributor

I think the root cause for this may actually be related to #5230 (the error messages look familiar)

I have a PR out for this in #5641, let's see if it resolves the issue!

@mamoodi
Copy link
Collaborator

mamoodi commented Dec 19, 2024

@malhotra5 since the PR has merged and released, do you think this is good to close?

@malhotra5
Copy link
Contributor

I think we're good to close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolver Related to OpenHands Resolver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants