Fix issue #5343: [Bug]: Frontend changes cause Python unit tests workflow to fail but not frontend workflow #5344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #5343.
The PR successfully resolves the original issue where TypeScript errors were only being caught in Python unit tests but not in frontend workflows. The solution addresses this through two key changes:
Fixed the immediate TypeScript error in chat-input.tsx with proper null checking for textareaRef.current, improving type safety.
More importantly, implemented two new GitHub workflow files that explicitly include TypeScript type checking in the frontend CI process:
These changes ensure that TypeScript type errors will be caught early in the frontend workflows rather than only appearing in Python unit tests. The PR successfully addresses both the specific typing issue and the broader CI process problem. All tests are now passing, and the implementation provides a more robust checking system for future frontend changes.
This is ready for review and provides a complete solution to the reported issue.
Automatic fix generated by OpenHands 🙌
To run this PR locally, use the following command: