You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These failures were caused by the typescript changes in this commit: fc6b4af
If we look at the changes in the commit, they are related to the frontend, not related to Python.
Building frontend...
> [email protected] build
> npm run make-i18n && tsc && remix vite:build
> [email protected] make-i18n
> node scripts/make-i18n-translations.cjs
src/components/chat-input.tsx(90,25): error TS18047: 'textareaRef.current' is possibly 'null'.
make[1]: *** [Makefile:188: build-frontend] Error 2
make: *** [Makefile:29: build] Error 2
Error: Process completed with exit code 2.
It shouldn't be the case that frontend changes cause frontend tests to pass but the Python Unit Test workflow to fail. All bad frontend changes should be caught by frontend testing workflows.
To fix this we can gradually create a PR to fix these issues:
carefully read all reference materials, the existing worfklows for "Lint / Lint frontend", "Run Frontend Unit Tests / FE Unit Tests", and "Python Unit Tests", as well as the output of the passing/failed github actions
create a dummy PR that uses the code in the above commit to see if you can reproduce the issue of the Python Unit Tests workflow failing but the frontend tests passing on this small frontend bug
try to fix the existing frontend workflows so that they also fail on this error
revert all changes to the typescript files and make sure that all workflows now pass
OpenHands Installation
Docker command in README
OpenHands Version
No response
Operating System
None
Logs, Errors, Screenshots, and Additional Context
No response
The text was updated successfully, but these errors were encountered:
Is there an existing issue for the same bug?
Describe the bug and reproduction steps
Sometimes changes to the frontend cause Python unit tests to fail, but do not cause the frontend workflows to fail.
Here is an example of workflows from the same commit:
These failures were caused by the typescript changes in this commit: fc6b4af
If we look at the changes in the commit, they are related to the frontend, not related to Python.
It shouldn't be the case that frontend changes cause frontend tests to pass but the Python Unit Test workflow to fail. All bad frontend changes should be caught by frontend testing workflows.
To fix this we can gradually create a PR to fix these issues:
OpenHands Installation
Docker command in README
OpenHands Version
No response
Operating System
None
Logs, Errors, Screenshots, and Additional Context
No response
The text was updated successfully, but these errors were encountered: