Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate browsergym updates #5239

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Separate browsergym updates #5239

merged 1 commit into from
Nov 24, 2024

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented Nov 24, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR proposes to put browsergym updates in their own group, to be reviewed separately from the rest.

The reason is that newer versions install nvidia-CUDA via a libvisualwebarena dependency

  • this has lead to failed CI because of out of space errors
  • we have torch and similar, set as optional deps under the evaluation poetry group (used for local embeddings), but I suppose we won't do that with browsergym

I seem to understand we will want visual web arena, so we may need to look into this. In any case, we have generally separated deps that are likely to break things, and this one looks like it needs its own.


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:273f8b9-nikolaik   --name openhands-app-273f8b9   docker.all-hands.dev/all-hands-ai/openhands:273f8b9

@enyst enyst requested review from rbren and neubig November 24, 2024 20:06
@enyst enyst mentioned this pull request Nov 24, 2024
1 task
@neubig neubig merged commit 36d85b6 into main Nov 24, 2024
13 checks passed
@neubig neubig deleted the enyst/browsergym-updates branch November 24, 2024 21:53
@enyst enyst mentioned this pull request Nov 30, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants