-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_thinking #5220
add_thinking #5220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Tomlili43 , thanks for the contribution!
In general, all prompts should be implemented in the Python backend, not the frontend. And if we add a new prompt we'll need to validate its effect on agent accuracy and cost.
If you're interested in adding this prompt, could you try adding it in the agenthub/codeact_agent
directory? (you can look at the directory structure there to understand what needs to be done)
We would then need to validate the effect of this change on performance and cost. I'm a bit worried that adding this big prompt in the input and encouraging longer outputs would lead to significant increases in time/token cost, but we could try a few examples to see if this makes a big difference in accuracy!
@neubig yeap,
|
Hey @Tomlili43 , we can try to do this, but it'd be good if you could try running a few examples first to see if it's working! |
@neubig hi, validation == run cmd: ./evaluation/agent_bench/scripts/run_infer.sh eval_thinking_prompt_llm HEAD CodeActAgent 1 |
Yep, that looks right. |
@Tomlili43 is this something you still wish to pursue? |
Going to close this. Please let me know if this was still in progress and we can reopen. |
End-user friendly description of the problem this fixes or functionality that this introduces
Agent thinking feature by thinking
Give a summary of what the PR does, explaining any non-trivial design decisions
add thinking prompt and thinking front end UI.
Link of any specific issues this addresses