Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: run-eval workflow is failing on git pull (due to fork?) #5228

Open
1 task done
neubig opened this issue Nov 23, 2024 · 9 comments
Open
1 task done

[Bug]: run-eval workflow is failing on git pull (due to fork?) #5228

neubig opened this issue Nov 23, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@neubig
Copy link
Contributor

neubig commented Nov 23, 2024

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

I tried to run the eval workflow on this PR (from a fork): #5220

It is failing with the following error:

Fetching the repository
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/add_thinking*:refs/remotes/origin/add_thinking* +refs/tags/add_thinking*:refs/tags/add_thinking*
  The process '/usr/bin/git' failed with exit code 1
  Waiting 19 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/add_thinking*:refs/remotes/origin/add_thinking* +refs/tags/add_thinking*:refs/tags/add_thinking*
  The process '/usr/bin/git' failed with exit code 1
  Waiting 16 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/add_thinking*:refs/remotes/origin/add_thinking* +refs/tags/add_thinking*:refs/tags/add_thinking*

I suspect that this might be due to the eval workflow not working on forks. @mamoodi it'd be great if you can investigate!

OpenHands Installation

Other

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response

@neubig neubig added the bug Something isn't working label Nov 23, 2024
@mamoodi mamoodi mentioned this issue Nov 25, 2024
1 task
@mamoodi
Copy link
Collaborator

mamoodi commented Nov 25, 2024

To comment, I'm aware of the issue. The fix needs a little pondering.

@mamoodi
Copy link
Collaborator

mamoodi commented Nov 25, 2024

The reason is github doesn't allow access to secrets from outside the repo, which is understandable.

@mamoodi
Copy link
Collaborator

mamoodi commented Dec 5, 2024

Might be a will not do for now. Will discuss with the team how to approach this.
For forks, the job can be run manually.

@enyst
Copy link
Collaborator

enyst commented Dec 5, 2024

@mamoodi Can you please tell, what do you mean by manually, how does that work or what does it imply?

@mamoodi
Copy link
Collaborator

mamoodi commented Dec 5, 2024

The remote job will have to be run manually by someone from the All Hands AI team if an eval needs to be run on a fork for now. Investigated a bit on how we can make this automatic and because secrets are not available in forks, it makes things hard.

Looking at the original eval-runner workflow, that one has secrets as well so that one also has the same problem.

@mamoodi
Copy link
Collaborator

mamoodi commented Dec 15, 2024

Going to close this as will not do for now. Running evals automatically through labelling on forks is not supported.

@mamoodi mamoodi closed this as completed Dec 15, 2024
@mamoodi
Copy link
Collaborator

mamoodi commented Dec 15, 2024

Reopening since enyst says this might be possible with a github app.

@mamoodi mamoodi reopened this Dec 15, 2024
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Inactive for 30 days label Jan 16, 2025
@enyst enyst removed the Stale Inactive for 30 days label Jan 16, 2025
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Inactive for 30 days label Feb 16, 2025
@enyst enyst removed the Stale Inactive for 30 days label Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants